Repository navigation
[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] No pop-over after bulk-selecting rates and trying to disable/delete them #38876
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56.0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38237
Issue reported by: Applause - Internal Team
Action Performed:
precondition: user created a collect policy in OD
- Go to https://staging.new.expensify.com/
and log in as the admin of the collect policy - Navigate to the workspace settings > More features
- Enable Distance rates
- Open Distance rates
- Tap bulk-select
- In the drop-down select Disable rates"/ "Delete rates"
- On the pop-over tap “Got it”
- Delete one distance rate
- Tap bulk select > Disable rates/Delete rates
Expected Result:
The same pop-over is displayed in step 6 and 9 notifying that at least one distance rate should be enabled
Actual Result:
The error message "There must be at least one enabled distance rate' is displayed instead of the pop-over the second time trying to disable the distance rates, the error on the distance rate edit screen is shown.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6424007_1711171299608.video_2024-03-23_01-21-21.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01da91acddaa976701
- Upwork Job ID: 1772188427745120256
- Last Price Increase: 2024-03-25
Activity
github-actions commentedon Mar 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Mar 23, 2024
We think that this bug might be related to #wave-collect - Release 1
melvin-bot commentedon Mar 23, 2024
Triggered auto assignment to @arosiclair (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.MrMuzyk commentedon Mar 25, 2024
I am Michał from Callstack - expert contributor group. I’d like to work on this job.
25 remaining items
melvin-bot commentedon Mar 29, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.mountiny commentedon Mar 29, 2024
$250 to @hoangzinh unless you have reviewed the offending PR too?
hoangzinh commentedon Mar 30, 2024
oh nope, the offending PR is not mine. Hehe
sonialiap commentedon Apr 5, 2024
@hoangzinh $250 - offer sent
hoangzinh commentedon Apr 5, 2024
Accepted. Thanks @sonialiap
melvin-bot commentedon Apr 5, 2024
Payment Summary
Upwork Job
BugZero Checklist (@sonialiap)
sonialiap commentedon Apr 8, 2024
Payment completed ✔️