Repository navigation
[HOLD for payment 2024-04-09] [$500] Composer defocuses when editing parent message in thread #38878
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37566
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com.
- Go to any chat.
- Send a message containing inline image markdown. Example:
An inline image and some text - Right click on the message > Edit comment.
- Focus the cursor anywhere in the editor.
- Note that the composer will not defocus.
- Right click on the message > Reply in thread.
- Right click on the parent message > Edit comment.
- Focus the cursor anywhere in the editor.
Expected Result:
The composer will not defocus.
Actual Result:
The composer defocuses when editing message with inline image mark down in thread.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6424058_1711173003900.20240323_134637.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~012dd2062cbe841507
- Upwork Job ID: 1772340169085984768
- Last Price Increase: 2024-03-25
- Automatic offers:
- jjcoffee | Reviewer | 0
- bernhardoj | Contributor | 0
Activity
github-actions commentedon Mar 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 23, 2024
Triggered auto assignment to @amyevans (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Mar 23, 2024
We think that this bug might be related to #vip-bills
amyevans commentedon Mar 25, 2024
This is related to a new feature and also pretty minor so not worth considering a blocker.
@kidroca do you have bandwidth to take this on and fix as polish? If not I can open it up to external proposals. cc @situchan @marcaaron
amyevans commentedon Mar 25, 2024
Hmm actually I'm going to walk back my comment that it's related to the Image Markdown PR, I think it was just incidental that it was discovered during QA there. I can reproduce the bug on
mainwith that PR reverted, and I can also reproduce on a comment that does not include image markdown.Will continue to investigate...
situchan commentedon Mar 25, 2024
Agree, I am not convinced why composer focus behavior is related to image MD.
[-]Image MD - Composer defocuses when editing message with inline image mark down in thread[/-][+][$500] Image MD - Composer defocuses when editing message with inline image mark down in thread[/+]29 remaining items
[-][$500] Composer defocuses when editing parent message in thread[/-][+][HOLD for payment 2024-04-09] [$500] Composer defocuses when editing parent message in thread[/+]melvin-bot commentedon Apr 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
isabelastisser commentedon Apr 9, 2024
@jjcoffee please complete the list above. Thanks!
isabelastisser commentedon Apr 9, 2024
The payments were processed in Upwork.
Waiting for @jjcoffee to complete the BZ list before this can be closed.
jjcoffee commentedon Apr 10, 2024
Regression Test Proposal
Do we agree 👍 or 👎
isabelastisser commentedon Apr 10, 2024
Hi @amyevans, do you agree that we should create the regression test with the steps above? Thanks!
amyevans commentedon Apr 10, 2024
@isabelastisser I think since the bug was caught during normal regression testing by Applause, it means that adding an explicit test case for this would be unnecessary. However if you want to be safe you can always open a GH for it and let Isabella make that call!
isabelastisser commentedon Apr 10, 2024
Thanks for the context, Amy! I agree and will close it then.