Skip to content

[HOLD for payment 2024-04-25] [$500] Android - Chat - Starting chat with specific number, user directed to hmm it's not here page #38879

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-25] [$500] Android - Chat - Starting chat with specific number, user directed to hmm it's not here page#38879
Assignees
deetergpjayeshmangwanibfitzexpensifynkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Mar 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.56
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4447645
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap fab --- start chat
  3. Enter +79585702746 and select the contact

Expected Result:

Starting chat with specific number, user must be directed to specific contact page

Actual Result:

Starting chat with specific number, user directed to hmm it's not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423987_1711162774974.err.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014f0c32c8537d50a1
  • Upwork Job ID: 1772777450410250240
  • Last Price Increase: 2024-04-03
  • Automatic offers:
    • jayeshmangwani | Reviewer | 0

Activity

  1. lanitochka17
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 23, 2024
  2. melvin-bot
    assigned
    bfitzexpensify
    on Mar 23, 2024

  3. melvin-bot commented on Mar 23, 2024

    @melvin-bot
    melvin-botBot
    on Mar 23, 2024 – with Melvin Bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. lanitochka17 commented on Mar 23, 2024

    @lanitochka17
    lanitochka17
    on Mar 23, 2024
    Author

    @bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Mar 23, 2024

    @lanitochka17
    lanitochka17
    on Mar 23, 2024
    Author

    We think that this bug might be related to #vip-vsp

  6. bfitzexpensify
    added this to [#whatsnext] #vip-vsbon Mar 27, 2024
  7. bfitzexpensify
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 27, 2024
  8. melvin-bot
    changed the title [-]Android - Chat - Starting chat with specific number, user directed to hmm it's not here page[/-] [+][$500] Android - Chat - Starting chat with specific number, user directed to hmm it's not here page[/+] on Mar 27, 2024

  9. melvin-bot commented on Mar 27, 2024

    @melvin-bot
    melvin-botBot
    on Mar 27, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~014f0c32c8537d50a1

  10. melvin-bot
    added
    Overdue
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 27, 2024

  11. melvin-bot commented on Mar 27, 2024

    @melvin-bot
    melvin-botBot
    on Mar 27, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  12. melvin-bot
    assigned
    jayeshmangwani
    on Mar 27, 2024
  13. melvin-bot
    removed
    Overdue
    on Mar 27, 2024

  14. 43 remaining items

  15. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
    • [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jayeshmangwani] Determine if we should create a regression test for this bug.
    • [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. bfitzexpensify
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 23, 2024
  17. melvin-bot
    added
    Overdue
    on Apr 23, 2024

  18. bfitzexpensify commented on Apr 23, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 23, 2024
    Contributor

    Switching this to daily to action on Thursday.

    @nkdengineer I sent an offer to you via Upwork.

    @jayeshmangwani please complete the BZ checklist - thank you!

  19. melvin-bot
    removed
    Overdue
    on Apr 23, 2024

  20. jayeshmangwani commented on Apr 23, 2024

    @jayeshmangwani
    jayeshmangwani
    on Apr 23, 2024
    Contributor

    @bfitzexpensify I will complete the checklist tomorrow

  21. jayeshmangwani commented on Apr 24, 2024

    @jayeshmangwani
    jayeshmangwani
    on Apr 24, 2024
    Contributor

    Regression Test Proposal

    1. Open App > Press FAB > Start chat
    2. Enter invalid phone number, i.e +79585702746
    3. After opening the report, verify that the error appears and the header doesn't display skeleton
    4. Clear the error
    5. Press FAB > Start chat again
    6. Verify that the phone number that we entered above doesn't appears as recent contact

    Do we agree 👍 or 👎

  22. melvin-bot
    added
    DailyKSv2
    and removed
    DailyKSv2
    on Apr 24, 2024

  23. bfitzexpensify commented on Apr 25, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 25, 2024
    Contributor

    Thanks @jayeshmangwani - proposed those steps be added via https://github.com/Expensify/Expensify/issues/390645.

    Payment will be completed tomorrow.

    @nkdengineer a reminder to accept the Upwork job offer.

  24. bfitzexpensify commented on Apr 26, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 26, 2024
    Contributor

    Payment to @jayeshmangwani complete. Bumping @nkdengineer in Slack again so we can close this out.

  25. nkdengineer commented on Apr 26, 2024

    @nkdengineer
    nkdengineer
    on Apr 26, 2024
    Contributor

    @bfitzexpensify Thanks for bumping, I accepted the offer 🙏

  26. bfitzexpensify commented on Apr 26, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 26, 2024
    Contributor

    Thanks! Payments complete. Closing this out

  27. bfitzexpensify
    closed this as completedon Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions