Skip to content

Workspace features - App redirects to not here page when the feature is disabled #38896

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-1
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37902
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is admin of Collect workspace.
  1. Go to staging.new.expensify.com.
  2. Go to Profile > Workspaces > Collect workspace.
  3. Go to More features.
  4. Open the same page in Step 3 in a second tab.
  5. In the first tab, go to tab of enabled feature.
    6.. From the second tab, disable the feature in Step 5.
  6. Copy URL to any feature.
  7. Disable the feature in Step 7.
  8. Navigate to the URL of disabled feature.

Expected Result:

In Step 6, the first tab will redirect to More features page.
In Step 9, app will redirect to More features page.

Actual Result:

In Step 6, the first tab redirects to not here page.
In Step 9, not here page shows up.

Additional Information:

For Step 1-6, reproducible on web only.
For Step 7-9, reproducible in all environment.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Step 1-6

Bug6424478_1711214953624.Step_1_to_6.mp4

Step 7-9

Bug6424478_1711214953656.Step_7_to_9.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Activity

  1. github-actions commented on Mar 24, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 24, 2024

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Mar 24, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-control

  4. allgandalf commented on Mar 24, 2024

    @allgandalf
    Contributor

    Looking at the conversation from #37902 it was later decided to show a not here page for the time being, so ig we can close this issue and NAB, isn't it @mountiny @getusha

  5. getusha commented on Mar 24, 2024

    @getusha
    Contributor

    That's right this was intentional.

  6. rezkiy37 commented on Mar 25, 2024

    @rezkiy37
    Contributor

    It works properly. The app shows the "Not found" when a feature is disabled.

  7. luacmartins commented on Mar 25, 2024

    @luacmartins
    Contributor

    Agree that this is the expected behavior. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions