Repository navigation
[HOLD for payment 2024-04-09] [$500] Expense - Page scrolls back down when dismissing add receipt RHP in transaction thread #38935
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
- Go to staging.new.expensify.com
- Create a manual request without receipt
- Go to request details page
- Scroll to the top of the page
- Click on add receipt thumbnail
- Click outside the RHP to dismiss it
Expected Result:
The page will not scroll down when closing the RHP (production behavior)
Actual Result:
The page scrolls down when closing the RHP
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6425973_1711372872772.20240325_151949.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01e4b313e99e0a0eca
- Upwork Job ID: 1772334661375188992
- Last Price Increase: 2024-03-25
Activity
github-actions commentedon Mar 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 25, 2024
Triggered auto assignment to @flodnv (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 25, 2024
We think that this bug might be related to #wave-collect - Release 1
lanitochka17 commentedon Mar 25, 2024
@flodnv FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
[-]Expense - Page scrolls back down when dismissing add receipt RHP in transaction thread[/-][+][$500] Expense - Page scrolls back down when dismissing add receipt RHP in transaction thread[/+]melvin-bot commentedon Mar 25, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e4b313e99e0a0eca
melvin-bot commentedon Mar 25, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)habasefa commentedon Mar 25, 2024
I couldn't reproduce this on dev but it is still there on staging.
28 remaining items
[-][$500] Expense - Page scrolls back down when dismissing add receipt RHP in transaction thread[/-][+][HOLD for payment 2024-04-09] [$500] Expense - Page scrolls back down when dismissing add receipt RHP in transaction thread[/+]melvin-bot commentedon Apr 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
kadiealexander commentedon Apr 9, 2024
@mananjadhav please complete the checklist!
mananjadhav commentedon Apr 9, 2024
Thanks for the bump @kadiealexander. We already discussed the offending PR with the explanation.
I don't think we need a regression test for this one.
melvin-bot commentedon Apr 9, 2024
Payment Summary
Upwork Job
BugZero Checklist (@kadiealexander)
JmillsExpensify commentedon Apr 10, 2024
$500 approved for @mananjadhav based on checklist above.