Skip to content

[HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] Chat – Action menu opens down when pressing on the top of highlighted message #39044

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in.
  3. Navigate to chat with a long conversation history
  4. Send a message
  5. Highlight the last message and open action menu right clicking on the top part of it

Expected Result:

Action menu opens up when pressing on the top of highlighted message

Actual Result:

Action menu opens down when pressing on the top of highlighted message. The part of opened menu is not visible, unable to scroll it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6428612_1711540562593.Menu.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2024
  2. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

  5. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    Author

    @puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #vip-vsb.

  7. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    Author

    Production

    bandicam.2024-03-27.14-06-49-813.mp4
  8. ZhenjaHorbach commented on Mar 27, 2024

    @ZhenjaHorbach
    Contributor

    Regression from this PR

    #38553

  9. puneetlath commented on Mar 27, 2024

    @puneetlath
    Contributor

    @dukenv0307 thoughts?

  10. 8 remaining items

  11. puneetlath commented on Mar 28, 2024

    @puneetlath
    Contributor

    Fix has been CP'd. Since it was fixed the the original PR author, I'm going to go ahead and close this issue.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 29, 2024
  13. changed the title [-]Chat – Action menu opens down when pressing on the top of highlighted message[/-] [+][HOLD for payment 2024-04-05] Chat – Action menu opens down when pressing on the top of highlighted message[/+] on Mar 29, 2024
  14. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

  16. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@puneetlath] The PR that introduced the bug has been identified. Link to the PR:
    • [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@puneetlath] Determine if we should create a regression test for this bug.
    • [@puneetlath] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. changed the title [-][HOLD for payment 2024-04-05] Chat – Action menu opens down when pressing on the top of highlighted message[/-] [+][HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] Chat – Action menu opens down when pressing on the top of highlighted message[/+] on Apr 2, 2024
  18. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-09. 🎊

  19. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@puneetlath] The PR that introduced the bug has been identified. Link to the PR:
    • [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@puneetlath] Determine if we should create a regression test for this bug.
    • [@puneetlath] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions