Skip to content

[HOLD for payment 2024-04-25] [$500] Chat - Compose Box is shown above empty space and doesn't resize properly #39061

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-25] [$500] Chat - Compose Box is shown above empty space and doesn't resize properly#39061
Assignees
JmillsExpensifytgolensuneoxsobitneupane
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@izarutskaya
izarutskaya
opened on Mar 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4459664
Email or phone of affected tester (no customers): gatantm@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to any chat
  2. Tap on the compose box
  3. Type a few lines and tap on expand icon

Expected Result:

The compose box is directly above the keyboard, expands with the first few lines added and expands to half the screen when tapping the expand icon

Actual Result:

The compose box has empty space between it and the keyboard, expands with the first few lines but either doesn't expand when tapping the expand icon or contracts.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6428664_1711543443184.RPReplay_Final1711543166.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013eedeeb058661915
  • Upwork Job ID: 1772998191642521600
  • Last Price Increase: 2024-03-27
  • Automatic offers:
    • suneox | Contributor | 0
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2024
  2. melvin-bot
    assigned
    JmillsExpensify
    on Mar 27, 2024

  3. melvin-bot commented on Mar 27, 2024

    @melvin-bot
    melvin-botBot
    on Mar 27, 2024 – with Melvin Bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 27, 2024

  5. github-actions commented on Mar 27, 2024

    @github-actions
    github-actionsBot
    on Mar 27, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot
    assigned
    tgolen
    on Mar 27, 2024

  7. melvin-bot commented on Mar 27, 2024

    @melvin-bot
    melvin-botBot
    on Mar 27, 2024 – with Melvin Bot

    Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    izarutskaya
    on Mar 27, 2024
    Author

    @JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  9. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    izarutskaya
    on Mar 27, 2024
    Author

    We think that this bug might be related to #vip-vsb.

  10. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    izarutskaya
    on Mar 27, 2024
    Author

    Production video

    RPReplay_Final1711548176.MP4
  11. tgolen
    changed the title [-]Chat - Compose Box is shown above empty space and doesn't recize properly[/-] [+]Chat - Compose Box is shown above empty space and doesn't resize properly[/+] on Mar 27, 2024

  12. 33 remaining items

  13. melvin-bot
    removed
    ReviewingHas a PR in review
    on Apr 18, 2024

  14. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sobitneupane] Determine if we should create a regression test for this bug.
    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Apr 24, 2024

  18. melvin-bot commented on Apr 29, 2024

    @melvin-bot
    melvin-botBot
    on Apr 29, 2024 – with Melvin Bot

    @JmillsExpensify, @tgolen, @suneox, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

  19. JmillsExpensify commented on Apr 30, 2024

    @JmillsExpensify
    JmillsExpensify
    on Apr 30, 2024
    Contributor

    Payment summary:

  20. melvin-bot
    removed
    Overdue
    on Apr 30, 2024

  21. JmillsExpensify commented on Apr 30, 2024

    @JmillsExpensify
    JmillsExpensify
    on Apr 30, 2024
    Contributor

    Contributor paid out. @sobitneupane since you're paid via Expensify, I'm going to close this issue, though please fill out the BZ checklist before requesting. Thanks!

  22. JmillsExpensify
    closed this as completedon Apr 30, 2024

  23. sobitneupane commented on May 7, 2024

    @sobitneupane
    sobitneupane
    on May 7, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #38755

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #38755 (comment)

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sobitneupane] Determine if we should create a regression test for this bug.

    Yes.

    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    #39061 (comment)

  24. sobitneupane commented on May 7, 2024

    @sobitneupane
    sobitneupane
    on May 7, 2024
    Contributor

    Regression Test Proposal

    1. Go to any chat in mWeb/Safari
    2. Tap on the compose box
    3. Type a few lines and tap on expand icon
    4. Verify that the compose box resizes properly.

    Do we agree 👍 or 👎

  25. JmillsExpensify commented on May 12, 2024

    @JmillsExpensify
    JmillsExpensify
    on May 12, 2024
    Contributor

    $500 approved for @sobitneupane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions