Skip to content

[HOLD for payment 2024-05-08] Web - Chat - Composer jumps when entering first emoji #39267

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1.Go to staging.new.expensify.com/
2.Go to any chat
3.Enter an emoji

Expected Result:

The composer will not jump

Actual Result:

The composer jumps when entering the first emoji

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

20240329_233527.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 29, 2024
  2. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Mar 29, 2024

    @m-natarajan
    Author

    We think this bug might be related to #vip-vsb

  6. m-natarajan commented on Mar 29, 2024

    @m-natarajan
    Author

    @slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. 38 remaining items

  8. melvin-bot commented on May 1, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-08. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on May 1, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
    • [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@BartoszGrajdek] Determine if we should create a regression test for this bug.
    • [@BartoszGrajdek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  10. slafortune commented on May 8, 2024

    @slafortune
    Contributor

    @BartoszGrajdek Can you complete the checklist above?

  11. slafortune commented on May 8, 2024

    @slafortune
    Contributor

    @BartoszGrajdek does not require payment (Contractor)

  12. BartoszGrajdek commented on May 8, 2024

    @BartoszGrajdek
    Contributor

    @BartoszGrajdek Can you complete the checklist above?

    I believe @Skalakid was the one who actually fixed this

  13. melvin-bot commented on May 8, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  14. fedirjh commented on May 13, 2024

    @fedirjh
    Contributor

    cc @slafortune Could you please reopen this issue to handle the payment for the C+ review? Thank you.

  15. slafortune commented on May 15, 2024

    @slafortune
    Contributor

    Shoot! I am sorry about that @fedirjh ! Offer sent here - https://www.upwork.com/nx/wm/offer/102318459

  16. fedirjh commented on May 15, 2024

    @fedirjh
    Contributor

    @slafortune Thank you. Accepted.

  17. slafortune commented on May 15, 2024

    @slafortune
    Contributor

    Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions