Skip to content

[HOLD for payment 2024-04-15] [$250] mWeb - Send money-In send money report page, an extra skeleton preview is displayed #39306

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on a report with no previous conversation
  3. Tap plus icon -- send money
    4.Enter an amount and tap next
    5.Tap pay elsewhere
    6.Open the newly created send money request

Expected Result:

In send money report page, an extra skeleton preview must not be displayed

Actual Result:

In send money report page, an extra skeleton preview is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6432066_1711746671484.study.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01523fec2621a20689
  • Upwork Job ID: 1773847838939754496
  • Last Price Increase: 2024-03-29
  • Automatic offers:
    • abdulrahuman5196 | Contributor | 0
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    @hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 29, 2024
  6. mountiny commented on Mar 29, 2024

    @mountiny
    Contributor

    I am going to take over this one, I think ti might be related to #36657 @dukenv0307 @abdulrahuman5196 the issue is actually minor and I dont think its a blocker

  7. mountiny commented on Mar 29, 2024

    @mountiny
    Contributor

    @abdulrahuman5196 @dukenv0307 could you please test if this occurs also in revert of the PR?

  8. 27 remaining items

  9. changed the title [-][$250] mWeb - Send money-In send money report page, an extra skeleton preview is displayed[/-] [+][HOLD for payment 2024-04-15] [$250] mWeb - Send money-In send money report page, an extra skeleton preview is displayed[/+] on Apr 8, 2024
  10. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Apr 15, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @Christinadobrzyn you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  13. Christinadobrzyn commented on Apr 16, 2024

    @Christinadobrzyn
    Contributor

    Payouts due:

    Upwork job is here.

    @mananjadhav should you be paid as the C+?

    @mananjadhav or @abdulrahuman5196 do we need a regression test?

  14. mananjadhav commented on Apr 16, 2024

    @mananjadhav
    Collaborator

    @Christinadobrzyn I don’t think any payouts are needed. IIRC this was a regression.

  15. Christinadobrzyn commented on Apr 16, 2024

    @Christinadobrzyn
    Contributor

    Oh thanks @mananjadhav - sorry @abdulrahuman5196 I just requested a refund for the $250 paid to you via Upwork. sorry about that - I should have asked before paying. Let me know if I'm missing anything

  16. abdulrahuman5196 commented on Apr 16, 2024

    @abdulrahuman5196
    Contributor
  17. Christinadobrzyn commented on Apr 17, 2024

    @Christinadobrzyn
    Contributor

    thank you @abdulrahuman5196 so sorry about that. I think this can be closed since there's no payments or regression test.

    Closing but let me know if I'm missing anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions