Skip to content

Web - Payment details is missing after Split Money when you click on green badge icon #3940

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.expensify.cash
  2. Log in with any account
  3. Click on Green button and click on Split
  4. Put amount and click next
  5. Select couple users and click next
  6. After Split Request is done select user which you requested money.
  7. Click on Green Badge Icon

Expected Result:

Payment details should be displayed

Actual Result:

Payment details is missing after Split Money when you click on green badge icon.

Workaround:

n/a

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: Build: 1.0.79-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
OS and browser used: Chrome
Is the issue reproducible in Prod: No

Video

View all open jobs on Upwork

Activity

  1. MelvinBot commented on Jul 9, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. MelvinBot commented on Jul 9, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 9, 2021
  4. OSBotify commented on Jul 9, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. Jag96 commented on Jul 9, 2021

    @Jag96
    Contributor

    I'm able to reproduce this on Production, on version 1.0.75-5, @mvtglobally what version on production were you unable to reproduce this on (1.0.79-0 doesn't exist yet)? I did notice that after splitting the bill, one of the two accounts did show the details properly when pressing the green badge icon.

    If you look at the URL bar, you can see that the URL is showing a duplicate reportID for the account that isn't showing the details, which seems to be the IOUReportID. So normally the URL would be expensify.cash/iou/details/chatReportID/IOUReportID, but in this case we're seeing expensify.cash/iou/details/IOUReportID/IOUReportID.

    After doing some logging it seems that after all the requests finish the reportIOUs_ value for the IOUReportID have the chatReportID set to the IOUReportID, so there must be a place where that value is getting set incorrectly in Onyx.

    Looks like the issue is that we're passing in the IOUReportID to getSimplifiedIOUReport here, when we should be passing the chatReportID. Going to remove the deployBlocker on this one, but since I sorted it out I'll make a PR and handle this one.

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 9, 2021
  7. isagoico commented on Jul 12, 2021

    @isagoico

    Issue not reproducible during KI retests (First Week)

  8. Jag96 commented on Jul 21, 2021

    @Jag96
    Contributor

    This has been fixed by #3946, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions