[HOLD for payment 2024-04-15] Fix deploy github action

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1712216796370159

Action Performed:

When @Expensify/mobile-deployers deploy the app in the usual way (see here)

Expected Result:

Prepare production deploy should have run fine like normal

Actual Result:

It failed, see: https://github.com/Expensify/App/actions/runs/8548605498/job/23422579684

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b3d5ebe5dc790d16
Upwork Job ID: 1775797869877637120
Last Price Increase: 2024-04-04

Job added to Upwork: https://www.upwork.com/jobs/~01b3d5ebe5dc790d16

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@thesahindia

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

Unassigning C+, sorry! Working on this internally, and it's pretty hard / maybe impossible to test locally

PR merged, will test this via the next deploy soon 🙏

success! closing!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Attempt to fix deploy script #39580

If no regressions arise, payment will be issued on 2024-04-15. 🎊

@Beamanator

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
[@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Beamanator] Determine if we should create a regression test for this bug.
[@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

no payment needed here, closing

oops i thought this was reopened on accident lol

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-15] Fix deploy github action #39581

Action Performed:

Expected Result:

Actual Result:

3 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-04-15] Fix deploy github action #39581

Description

Action Performed:

Expected Result:

Actual Result:

Activity

melvin-bot commented on Apr 4, 2024

melvin-bot commented on Apr 4, 2024

melvin-bot commented on Apr 4, 2024

Beamanator commented on Apr 4, 2024

3 remaining items

Beamanator commented on Apr 4, 2024

Beamanator commented on Apr 4, 2024

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

Beamanator commented on Apr 8, 2024

Beamanator commented on Apr 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions