Repository navigation
Make outline consistent for all focusable elements in the APP across platforms. #3959
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open any convo on E.cash on the web.
- Try to use the tab for navigation.
- See multiple elements get focus with an outline that is different across the platforms.
Expected Result:
- same Color of outline for each platform.
Actual Result:
Describe what actually happened
- Web(chrome) shows black solid.
- Web Firebox shows dotted line.
- Desktop has a yellow border.
- ETC...
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Just a UI thing.
Platform:
Where is this issue occurring?
Web ✔️
iOS
Android
Desktop App ✔️
Mobile Web
Version Number: Latest
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
cc: @shawnborton
Activity
MelvinBot commentedon Jul 9, 2021
Triggered auto assignment to @stephanieelliott (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.stephanieelliott commentedon Jul 14, 2021
Was able to demo this by following the reproduction steps 👍
MelvinBot commentedon Jul 14, 2021
Triggered auto assignment to @ctkochan22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Jul 16, 2021
Triggered auto assignment to @jboniface (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.27 remaining items
jboniface commentedon Jul 22, 2021
reminder to self to pay bonus for this (if i fail to do this let me know, raj)
MonilBhavsar commentedon Jul 29, 2021
@jboniface PR is merged, Reopening for payment
Julesssss commentedon Aug 2, 2021
@parasharrajat it looks like this PR introduced a regression.
On commit
f99dea6bfI see this:parasharrajat commentedon Aug 2, 2021
@Julesssss This is not a regression from this PR. I fixed the outline styles for the whole app which was wrong. If any other input in the app is showing this effect and this is a regression from this PR. but all other inputs are working fine.
I just checked that that Component is using
overflow:hiddenwhich will hide every outline which I verified by reverting my changes.Please let me know if you want me to fix that issue.
Julesssss commentedon Aug 2, 2021
Ah, I see. Thanks for explaining! Yep that would be great, but I'll discuss further on the raised issue.
MelvinBot commentedon Aug 3, 2021
@tgolen, @parasharrajat, @jboniface it looks like no one is assigned to work on this job.
Please double the price or add a comment stating why the job isn't being doubled.
parasharrajat commentedon Aug 3, 2021
Ding Ding. It's done.
jboniface commentedon Aug 5, 2021
paid
botify commentedon Aug 5, 2021
@tgolen @jboniface Be sure to fill out the Contact List!