Taxes - Missing tax rates in currency default list & app crashes when clicking on foreign rate

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
2.Create a new (Collect) workspace.
Go to Collect workspace settings > More features
Toggle on Taxes.
Go to Taxes tab.
Click Settings > Workspace currency default.
Go to Foreign currency default.
Click on the selected default tax.

Expected Result:

In Step 6 and 7, all other available taxes will show up in the list.
In Step 8, app will not crash.

Actual Result:

In Step 6 and 7, only the selected default tax shows up in the list.
In Step 8, app crashes

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6437926_1712233913737.default_tax_and_crash.mp4

View all open jobs on GitHub

@pecanoro

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - Missing tax rates in currency default list & app crashes when clicking on foreign rate

What is the root cause of that problem?

Actually looks like the BE issue
Because when we choose the same Workspace currency we get from BE new empty tax
As result we get crash that we try to get name from undefined

App/src/pages/workspace/taxes/WorkspaceTaxesSettingsWorkspaceCurrency.tsx

Lines 36 to 39 in 00d5cea

    
           const submit = ({keyForList}: ListItem) => { 
        
               setWorkspaceCurrencyDefault(policyID, keyForList ?? ''); 
        
               Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID)); 
        
           };

What changes do you think we should make in order to solve the problem?

To fix this issue we can add condition to just close current screen when we choose the same value without selecting the value

        if (selectedTaxRate === keyForList) {
            Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
            return;
        }

And we can filter the list when we don't have mandatory values( Or just update name like (value?.name ?? '') and other fields)

App/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

Lines 70 to 97 in 58e1b4b

    
           const taxesList = useMemo<ListItem[]>( 
        
               () => 
        
                   Object.entries(policy?.taxRates?.taxes ?? {}) 
        
                       .map(([key, value]) => ({ 
        
                           text: value.name, 
        
                           alternateText: textForDefault(key), 
        
                           keyForList: key, 
        
                           isSelected: !!selectedTaxesIDs.includes(key), 
        
                           isDisabledCheckbox: key === defaultExternalID, 
        
                           pendingAction: value.pendingAction, 
        
                           errors: value.errors, 
        
                           rightElement: ( 
        
                               <View style={styles.flexRow}> 
        
                                   <Text style={[styles.disabledText, styles.alignSelfCenter]}> 
        
                                       {value.isDisabled ? translate('workspace.common.disabled') : translate('workspace.common.enabled')} 
        
                                   </Text> 
        
                                   <View style={[styles.p1, styles.pl2]}> 
        
                                       <Icon 
        
                                           src={Expensicons.ArrowRight} 
        
                                           fill={theme.icon} 
        
                                       /> 
        
                                   </View> 
        
                               </View> 
        
                           ), 
        
                       })) 
        
                       .sort((a, b) => a.text.localeCompare(b.text)), 
        
               [policy?.taxRates?.taxes, textForDefault, defaultExternalID, selectedTaxesIDs, styles, theme.icon, translate], 
        
           );

What alternative solutions did you explore? (Optional)

NA

@ZhenjaHorbach

@ZhenjaHorbach don't add proposals until the Help Wanted is applied. Since this a deploy blocker, I am looking for this to get fixed by whoever broke it.

I am confident this deploy blocker is coming from #33927

Looking...

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

@teneeto

@teneeto Any updates on this? It's a deploy blocker so we either need to fix it asap or revert the original PR

latest from slack https://expensify.slack.com/archives/C03UK30EA1Z/p1712258281600879?thread_ts=1700633473.392829&cid=C03UK30EA1Z

PR is up #39646

PR is merged. Requested CP

Works well, no action required here

Screen.Recording.2024-04-05.at.6.18.06.PM.mov

All done, closing!

Navigation Menu

Repository navigation

Taxes - Missing tax rates in currency default list & app crashes when clicking on foreign rate #39602

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const submit = ({keyForList}: ListItem) => {
	setWorkspaceCurrencyDefault(policyID, keyForList ?? '');
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

	const taxesList = useMemo<ListItem[]>(
	() =>
	Object.entries(policy?.taxRates?.taxes ?? {})
	.map(([key, value]) => ({
	text: value.name,
	alternateText: textForDefault(key),
	keyForList: key,
	isSelected: !!selectedTaxesIDs.includes(key),
	isDisabledCheckbox: key === defaultExternalID,
	pendingAction: value.pendingAction,
	errors: value.errors,
	rightElement: (
	<View style={styles.flexRow}>
	<Text style={[styles.disabledText, styles.alignSelfCenter]}>
	{value.isDisabled ? translate('workspace.common.disabled') : translate('workspace.common.enabled')}
	</Text>
	<View style={[styles.p1, styles.pl2]}>
	<Icon
	src={Expensicons.ArrowRight}
	fill={theme.icon}
	/>
	</View>
	</View>
	),
	}))
	.sort((a, b) => a.text.localeCompare(b.text)),
	[policy?.taxRates?.taxes, textForDefault, defaultExternalID, selectedTaxesIDs, styles, theme.icon, translate],
	);

Taxes - Missing tax rates in currency default list & app crashes when clicking on foreign rate #39602

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 4, 2024

github-actions commented on Apr 4, 2024

kbecciv commented on Apr 4, 2024

ZhenjaHorbach commented on Apr 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

pecanoro commented on Apr 4, 2024

pecanoro commented on Apr 4, 2024

MonilBhavsar commented on Apr 4, 2024

teneeto commented on Apr 4, 2024

pecanoro commented on Apr 4, 2024

MonilBhavsar commented on Apr 4, 2024

MonilBhavsar commented on Apr 4, 2024

MonilBhavsar commented on Apr 5, 2024

MonilBhavsar commented on Apr 5, 2024

pecanoro commented on Apr 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions