Repository navigation
[Awaiting Payment 22nd May] [$250] [Track Tax] - Support for tax tracking when offline #39616
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #33927
Action Performed:
Precondition:
- User is an employee of Collect workspace that has taxes
- One of the tax rates is 0%
- Go to staging.new.expensify.com
- Go to workspace chat
- Create a manual request with tax
- Go to transaction thread
- Go offline
- Click on Tax rate and change to a lower tax rate
- Click Amount and change the amount
- Cick Tax amount
- Click Save without editing the amount
Expected Result:
In Step 6 and 7, when changing request amount and tax rate offline, the tax amount will change accordingly
Actual Result:
In Step 6 and 7, when changing request amount and tax rate offline, the tax amount does not update.
However, when saving invalid tax amount, the error message does show the updated maximum allowed tax amount
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6437972_1712235846086.bandicam_2024-04-04_21-00-05-673.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01b5995687f97137eb
- Upwork Job ID: 1777600527434604544
- Last Price Increase: 2024-04-09
Activity
melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to @johnmlee101 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 4, 2024
@johnmlee101 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 4, 2024
We think that this bug might be related to #wave-collect - Release 1
MonilBhavsar commentedon Apr 4, 2024
This is not a deploy blocker
The feature is being rolled out and we just discussed this yesterday and will be implementing soon
https://expensify.slack.com/archives/C03UK30EA1Z/p1712146178754839?thread_ts=1700633473.392829&cid=C03UK30EA1Z
MonilBhavsar commentedon Apr 4, 2024
@johnmlee101 I can handle this issue if you are fine with it
johnmlee101 commentedon Apr 4, 2024
Go ahead!
51 remaining items
zanyrenney commentedon May 9, 2024
Need BZ team to manage payment. I had this issue #41881
But when I asked @getusha to accept the job and they said:
But there was no BZer assigned.
trjExpensify commentedon May 10, 2024
Cool, @getusha confirming the PR is still in progress and no payment is necessary yet?
melvin-bot commentedon May 17, 2024
@trjExpensify, @teneeto, @MonilBhavsar, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!
trjExpensify commentedon May 20, 2024
Deployed to prod 5 days ago.
[-][$250] [Track Tax] - Support for tax tracking when offline[/-][+][Awaiting Payment 22nd May] [$250] [Track Tax] - Support for tax tracking when offline[/+]MonilBhavsar commentedon May 23, 2024
I think we can pay now
trjExpensify commentedon May 23, 2024
Payment summary as follows:
$250 to @getusha for the C+ review
trjExpensify commentedon May 23, 2024
Paid, closing!
getusha commentedon May 23, 2024
@trjExpensify accepted the offer, could you end it? thanks
trjExpensify commentedon May 23, 2024
Yep, it's paid. 👍