Repository navigation
[HOLD for payment 2024-06-24][$1000] Correct chat is not opening when typing someone's name and hit Enter in chat switcher #39631
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60-1
Reproducible in staging?: Yes
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @flodnv
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712242871375939
Action Performed:
Note: This seems to only (or maybe mainly) happen immediately after startup.
- Quit and restart desktop app
- Change chat with the mouse (click on another chat in the LHN)
- Change chat with chat switcher, all using the keyboard
- Hit enter to go to other chat
- Observe that I am still in the same chat
OR
- Quit and restart desktop app
- Change chat with chat switcher all using the keyboard (hit Cmd+K),
- Hit enter to go to another chat (not the currently open one)
- Observe that I am still in the same chat
Expected Result:
Navigates to the correct chat
Actual Result:
Observe app didn't navigate to that chat but stayed on the original one
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
2024-04-04_09-52-30.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01741289e82422ca9a
- Upwork Job ID: 1775934748241137664
- Last Price Increase: 2024-06-03
- Automatic offers:
- fedirjh | Reviewer | 102862846
- dominictb | Contributor | 102862847
Activity
melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.adelekennedy commentedon Apr 4, 2024
I can't reproduce reliably (but that's the same for Matt and Flo) however I think this is annoying enough that we should fix
melvin-bot commentedon Apr 4, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01741289e82422ca9a
[-]Correct chat is not opening when typing someone's name and hit `Enter` in chat switcher[/-][+][$250] Correct chat is not opening when typing someone's name and hit `Enter` in chat switcher[/+]melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)adelekennedy commentedon Apr 4, 2024
@fedirjh do you think this can be an external issue?
fedirjh commentedon Apr 4, 2024
@adelekennedy Yes, it's external. However, I am unable to reproduce it.
CleanShot.2024-04-04.at.18.29.14.mp4
adelekennedy commentedon Apr 4, 2024
same - however both Flo and Matt are able to reproduce intermittently so I think it's worth it to fix as it's a pretty frustrating one
134 remaining items
dominictb commentedon Jun 22, 2024
@mallenexpensify got it! Thanks for the input! I guess when things are due, I'll ping both issues then.
Do I need to be assigned here first?
melvin-bot commentedon Jun 24, 2024
📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Jun 24, 2024
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
[-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [HOLD #42558] [$1000] Correct chat is not opening when typing someone's name and hit `Enter` in chat switcher[/-][+]HOLD for payment 2024-06-24][$1000] Correct chat is not opening when typing someone's name and hit `Enter` in chat switcher[/+][-]HOLD for payment 2024-06-24][$1000] Correct chat is not opening when typing someone's name and hit `Enter` in chat switcher[/-][+][HOLD for payment 2024-06-24][$1000] Correct chat is not opening when typing someone's name and hit `Enter` in chat switcher[/+]mallenexpensify commentedon Jun 25, 2024
@fedirjh @dominictb , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01741289e82422ca9a
Fedi, the assignment of this job predates your eligible date to be paid via NewDot.
fedirjh commentedon Jun 25, 2024
@mallenexpensify I think I am not eligible for payment in this issue.
dominictb commentedon Jun 25, 2024
@mallenexpensify I accepted the job, TY
mallenexpensify commentedon Jun 26, 2024
Contributor: @dominictb paid $1000 via Upwork
Thanks @fedirjh , it looks like you didn't review the PR nor any proposals here.
@dominictb I've been running into an issue where, after typing cmd+k then typing a user's name, I need to hit enter twice to open the chat. Might that be related here? (sidenote: I'm also stuck a couple versions back on desktop
TestRail GH
dominictb commentedon Jun 26, 2024
I'm not sure @mallenexpensify. Could you report a bug?
Also, I couldn't access the link https://github.com/Expensify/Expensify/issues/407748 (internal-only link).