Skip to content

[HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline #39689

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4476117
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User A and have no unsettled IOU.
  1. Go to staging.new.expensify.com
  2. [User A] Request money from User B.
  3. [User A] Go offline.
  4. [User B] Pay the request.
  5. [User A] Delete the request while offline.
  6. [User A] Go online.
  7. [User A] Go to transaction thread (one report view).

Expected Result:

The error "Unexpected error deleting the money request, please try again later" should be present in one transaction report view.

Actual Result:

There is RBR for one transaction report in LHN, but there is no error in the report itself.
This issue happens when there is only one request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6438412_1712261176833.20240405_035838.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ebfa7c151ee18ff6
  • Upwork Job ID: 1776224622646538240
  • Last Price Increase: 2024-04-12
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 0
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 5, 2024
  2. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    @alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    Production

    bandicam.2024-04-05.11-47-52-412.mp4
  8. mountiny commented on Apr 5, 2024

    @mountiny
    Contributor

    This is a specific and rare flow so I dont think we have to hold the deploy on this one.

    This is related to the combined view cc @NikkiWines

    I think we can make this external

  9. 48 remaining items

  10. changed the title [-][$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline[/-] [+][HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline[/+] on Jun 6, 2024
  11. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-13. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. alexpensify commented on Jun 7, 2024

    @alexpensify
    Contributor

    @kaushiktd - you didn't get an offer since the automation failed here: #39689 (comment)

    I'll need to manually create a new request in Upwork before the payment due date. When it's ready, I'll reply here.

  15. kaushiktd commented on Jun 7, 2024

    @kaushiktd
    Contributor

    Thank you @alexpensify. Earlier I was able to receive an offer on my Upwork from Melvin but it stopped for the last couple of months. Do you have any idea what can be an issue?

  16. alexpensify commented on Jun 7, 2024

    @alexpensify
    Contributor

    I don't know about a couple of months ago, the issue that I'm describing today is a recent one. Either way, it's on my radar and I'll deal with it manually. I'll have an update early next week because the payment date is 2024-06-13.

  17. alexpensify commented on Jun 12, 2024

    @alexpensify
    Contributor

    Ok, ready for the payment process in Upwork. @kaushiktd - I've created a new Upwork job, please accept here:

    https://www.upwork.com/jobs/~01bce135ee5dd897fc

    Thanks!

  18. kaushiktd commented on Jun 13, 2024

    @kaushiktd
    Contributor

    Offer accepted on Upwork @alexpensify

  19. alexpensify commented on Jun 13, 2024

    @alexpensify
    Contributor

    Paid via Upwork!

    Payouts due: 2024-06-13

    Upwork job is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions