You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline #39689
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline[/-][+][HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline[/+]on Jun 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Thank you @alexpensify. Earlier I was able to receive an offer on my Upwork from Melvin but it stopped for the last couple of months. Do you have any idea what can be an issue?
I don't know about a couple of months ago, the issue that I'm describing today is a recent one. Either way, it's on my radar and I'll deal with it manually. I'll have an update early next week because the payment date is 2024-06-13.
Activity
melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 5, 2024
@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 5, 2024
We think this issue might be related to the #collect project.
izarutskaya commentedon Apr 5, 2024
Production
bandicam.2024-04-05.11-47-52-412.mp4
mountiny commentedon Apr 5, 2024
This is a specific and rare flow so I dont think we have to hold the deploy on this one.
This is related to the combined view cc @NikkiWines
I think we can make this external
48 remaining items
[-][$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline[/-][+][HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline[/+]melvin-bot commentedon Jun 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
alexpensify commentedon Jun 7, 2024
@kaushiktd - you didn't get an offer since the automation failed here: #39689 (comment)
I'll need to manually create a new request in Upwork before the payment due date. When it's ready, I'll reply here.
kaushiktd commentedon Jun 7, 2024
Thank you @alexpensify. Earlier I was able to receive an offer on my Upwork from Melvin but it stopped for the last couple of months. Do you have any idea what can be an issue?
alexpensify commentedon Jun 7, 2024
I don't know about a couple of months ago, the issue that I'm describing today is a recent one. Either way, it's on my radar and I'll deal with it manually. I'll have an update early next week because the payment date is 2024-06-13.
alexpensify commentedon Jun 12, 2024
Ok, ready for the payment process in Upwork. @kaushiktd - I've created a new Upwork job, please accept here:
https://www.upwork.com/jobs/~01bce135ee5dd897fc
Thanks!
kaushiktd commentedon Jun 13, 2024
Offer accepted on Upwork @alexpensify
alexpensify commentedon Jun 13, 2024
Paid via Upwork!
Payouts due: 2024-06-13
Upwork job is here