[HOLD for payment 2024-04-15] [$125] Tax - App crashes when changing tax rate offline, options not clickable on web&console error

@stephanieelliott

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Found when executing PR: #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: user is an employee of a collect policy, and tax is enabled OD

Open the app and log in as an employee
Open the workspace chat
Disable internet connection
Tap "+" > Request money > Manual
Enter the amount and tap next
Tap Show more and select a tax rate
Request money
Open the expense
Tap the tax and select a tax rate

Expected Result:

The tax is displayed in the tax field, and the user can select a different one.

Actual Result:

The app crashes after opening the tax rate and selecting a different one. The tax options are not responsive on the web, and there are console errors.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6438748_1712288519367.Recording__374.mp4

Bug6438748_1712288519354.IMG_6193.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013bd787d14b4b4b3e
Upwork Job ID: 1776216138504876032
Last Price Increase: 2024-04-15
Automatic offers:

abdulrahuman5196 | Reviewer | 0
dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @stephanieelliott

@nkuoch

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@stephanieelliott

@stephanieelliott I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes after opening the tax rate and selecting a different one. The tax options are not responsive on the web, and there are console errors.

What is the root cause of that problem?

policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)] can be undefined

App/src/libs/ReportUtils.ts

Line 2786 in 8fe465d

    
           originalMessage.oldTaxRate = policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)].value;

What changes do you think we should make in order to solve the problem?

Update this line to

        originalMessage.oldTaxRate = policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)]?.value;

What alternative solutions did you explore? (Optional)

NA

I can help here

Reviewing label has been removed, please complete the "BugZero Checklist".

@abdulrahuman5196

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix crash when tax rate is deleted #39707

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment automatic offer (Reviewer)
@dukenv0307 requires payment automatic offer (Contributor)

@abdulrahuman5196

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196 / @dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196 / @dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196 / @dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196 / @dukenv0307] Determine if we should create a regression test for this bug.
[@abdulrahuman5196 / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

No C+ required here. Unassigning myself.

Upwork job price has been updated to $125

@stephanieelliott

Awaiting payment @stephanieelliott $125 to @dukenv0307

@dukenv0307

Summarizing payment on this issue:

Contributor: $125 @dukenv0307 PAID via Upwork
Contributor+: N/A

Upwork job is here: https://www.upwork.com/jobs/~013bd787d14b4b4b3e

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-15] [$125] Tax - App crashes when changing tax rate offline, options not clickable on web&console error #39691

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

21 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-04-15] [$125] Tax - App crashes when changing tax rate offline, options not clickable on web&console error #39691

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 5, 2024

melvin-bot commented on Apr 5, 2024

github-actions commented on Apr 5, 2024

izarutskaya commented on Apr 5, 2024

izarutskaya commented on Apr 5, 2024

dukenv0307 commented on Apr 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mountiny commented on Apr 5, 2024

21 remaining items

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

abdulrahuman5196 commented on Apr 12, 2024

melvin-bot commented on Apr 15, 2024

mountiny commented on Apr 15, 2024

stephanieelliott commented on Apr 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions