Skip to content

[HOLD for payment 2024-04-15] [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time #39701

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-15] [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time#39701
Assignees
MonilBhavsarbfitzexpensifynkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@izarutskaya
izarutskaya
opened on Apr 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User is an employee of Collect workspace with tax rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual request with tax exempt (0%).
  4. Go to transaction thread.
  5. Click Tax amount.
  6. Save it without entering any amount.
  7. Repeat Step 5 and 6.

Expected Result:

In Step 6, when saving 0.00 tax amount, the system message will not show $NaN amount,
In Step 7, when saving 0.00 tax amount for the second time, the app will not show skeleton loading.

Actual Result:

In Step 6, $NaN is shown briefly in the system message.
In Step 7, transaction thread shows skeleton loading when saving 0.00 tax amount for second time.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6438827_1712298111790.20240405_141500.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01091a68b65c340a6a
  • Upwork Job ID: 1776234872385998848
  • Last Price Increase: 2024-04-05
  • Automatic offers:
    • DylanDylann | Reviewer | 0

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 5, 2024
  2. melvin-bot
    assigned
    cristipaval
    on Apr 5, 2024

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot
    melvin-botBot
    on Apr 5, 2024 – with Melvin Bot

    Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot
    assigned
    bfitzexpensify
    on Apr 5, 2024

  5. melvin-bot commented on Apr 5, 2024

    @melvin-bot
    melvin-botBot
    on Apr 5, 2024 – with Melvin Bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Apr 5, 2024

  7. github-actions commented on Apr 5, 2024

    @github-actions
    github-actionsBot
    on Apr 5, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    izarutskaya
    on Apr 5, 2024
    Author

    @bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  9. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    izarutskaya
    on Apr 5, 2024
    Author

    We think this issue might be related to the #collect project.

  10. MonilBhavsar commented on Apr 5, 2024

    @MonilBhavsar
    MonilBhavsar
    on Apr 5, 2024
    Contributor

    Looking here...

  11. MonilBhavsar
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 5, 2024

  12. 33 remaining items

  13. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Apr 8, 2024
  14. melvin-bot
    changed the title [-][$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time[/-] [+][HOLD for payment 2024-04-15] [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time[/+] on Apr 8, 2024
  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Apr 8, 2024

  16. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

    • @nkdengineer requires payment (Needs manual offer from BZ)

  18. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
    • [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@nkdengineer] Determine if we should create a regression test for this bug.
    • [@nkdengineer] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 14, 2024

  20. melvin-bot commented on Apr 15, 2024

    @melvin-bot
    melvin-botBot
    on Apr 15, 2024 – with Melvin Bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@bfitzexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1776234872385998848/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  21. bfitzexpensify commented on Apr 16, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 16, 2024
    Contributor

    I don't think a specific regression test is needed for this - it should be caught in regular tax testing.

    Payment complete, so closing this one out.

  22. bfitzexpensify
    closed this as completedon Apr 16, 2024

  23. nkdengineer commented on Jul 1, 2024

    @nkdengineer
    nkdengineer
    on Jul 1, 2024
    Contributor

    Sorry @bfitzexpensify It seems I wasn't paid here, could you reopen the issue to help with this?

    TIA

  24. bfitzexpensify commented on Jul 1, 2024

    @bfitzexpensify
    bfitzexpensify
    on Jul 1, 2024
    Contributor

    @nkdengineer this one was paid on April 16th - title for the Upwork job was Reviewer - [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions