Skip to content

[HOLD for payment 2024-04-15] [$500] Start chat - App shows data from User A after logging out of User A and logging in with User B #39710

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-15] [$500] Start chat - App shows data from User A after logging out of User A and logging in with User B#39710
Assignees
puneetlathpaultsimurabernhardoj
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Apr 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.60-8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory around https://expensify.testrail.io/index.php?/tests/view/4476067
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Account A and B are under the same private domain, and they share the same list of contacts.
  • Account A and B have different set of Recent contacts in Start chat list.
  1. Close and open incognito mode again for a fresh session.
  2. Go to staging.new.expensify.com
  3. Log in as Account A.
  4. Go to FAB > Start chat > Chat.
  5. Note that list of five contacts in Recent section.
  6. Log out and log in as Account B.
  7. Go to FAB > Start chat > Chat.
  8. Note that Account B has the exact same list of five contacts in Recent section as Account A.
  9. Close and open incognito mode.
  10. Repeat Step 6 and 7 for Account B.

Expected Result:

When user logs out and logs in with another account, the Recent section list will follow the data from the logged-in account.

Actual Result:

When user logs out from Account A and logs in with Account B, the Recent section list still shows the data from Account A.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6439021_1712310651825.20240405_174248.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e820a2af95c4423e
  • Upwork Job ID: 1776276873995067392
  • Last Price Increase: 2024-04-05
  • Automatic offers:
    • paultsimura | Reviewer | 0
    • bernhardoj | Contributor | 0
Issue OwnerCurrent Issue Owner: @puneetlath

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 5, 2024
  2. melvin-bot
    assigned
    puneetlath
    on Apr 5, 2024

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot
    melvin-botBot
    on Apr 5, 2024 – with Melvin Bot

    Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. kbecciv commented on Apr 5, 2024

    @kbecciv
    kbecciv
    on Apr 5, 2024
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. github-actions
    added
    Engineering
    HourlyKSv2
    on Apr 5, 2024

  6. github-actions commented on Apr 5, 2024

    @github-actions
    github-actionsBot
    on Apr 5, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. mountiny commented on Apr 5, 2024

    @mountiny
    mountiny
    on Apr 5, 2024
    Contributor

    I think this does not have to be a blocker

    @kbecciv @kavimuru does the account B not know the recents accounts it shows?

  8. kavimuru commented on Apr 5, 2024

    @kavimuru
    kavimuru
    on Apr 5, 2024

    @mountiny Logged in with old account with recent contacts, then logged out and sign up with a completely new account. The contact list with old account still shows up for new account.

    bandicam.2024-04-05.22-12-52-747.mp4

  9. mountiny commented on Apr 5, 2024

    @mountiny
    mountiny
    on Apr 5, 2024
    Contributor

    @TMisiukiewicz Could it be that we do not clear the cache for the search options in this case?

  10. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 5, 2024
  11. melvin-bot
    changed the title [-]Start chat - App shows data from User A after logging out of User A and logging in with User B[/-] [+][$250] Start chat - App shows data from User A after logging out of User A and logging in with User B[/+] on Apr 5, 2024

  12. melvin-bot commented on Apr 5, 2024

    @melvin-bot
    melvin-botBot
    on Apr 5, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01e820a2af95c4423e

  13. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 5, 2024
  14. melvin-bot
    assigned
    paultsimura
    on Apr 5, 2024

  15. 31 remaining items

  16. mountiny
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 8, 2024

  17. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

  18. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 8, 2024

  19. mountiny commented on Apr 8, 2024

    @mountiny
    mountiny
    on Apr 8, 2024
    Contributor

    Thanks @kbecciv it was repro because the desktop build failed before

    @puneetlath this will be ready for payment $500 to @bernhardoj and to @paultsimura

  20. puneetlath commented on Apr 8, 2024

    @puneetlath
    puneetlath
    on Apr 8, 2024
    Contributor

    Sorry, to clarify, you're saying I should pay them now? Or on April 15th?

  21. melvin-bot
    added
    Overdue
    on Apr 11, 2024

  22. melvin-bot commented on Apr 12, 2024

    @melvin-bot
    melvin-botBot
    on Apr 12, 2024 – with Melvin Bot

    @puneetlath, @paultsimura, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  23. paultsimura commented on Apr 13, 2024

    @paultsimura
    paultsimura
    on Apr 13, 2024
    Contributor

    Sorry, to clarify, you're saying I should pay them now? Or on April 15th?

    On April 15th.

    Not overdue, Melv.

  24. paultsimura commented on Apr 13, 2024

    @paultsimura
    paultsimura
    on Apr 13, 2024
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: perf: Cache search options #38207
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38207/files#r1563935428
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: Yes
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Accounts A and B share the same list of contacts
    • Accounts A and B have different sets of "Recent" contacts in the "Start chat" list.

    Test:

    1. Log in as Account A
    2. Go to FAB > Start chat > Chat
    3. Note the list of five contacts in the "Recent" section
    4. Log out and log in as Account B
    5. Go to FAB > Start chat > Chat
    6. Verify the "Recent" lists are different (unless they were indeed interacted with in the same order by both accounts A and B).

    Do we agree 👍 or 👎

  25. melvin-bot
    added
    DailyKSv2
    and removed
    DailyKSv2
    Overdue
    on Apr 14, 2024

  26. puneetlath commented on Apr 15, 2024

    @puneetlath
    puneetlath
    on Apr 15, 2024
    Contributor

    All paid. Thanks everyone!

  27. puneetlath
    closed this as completedon Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions