[HOLD #8267] Web - Read messages are marked unread after a while

@iwiznia

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open an unread chat
Navigate to other chats and use the app for a little while

Expected Result:

Unread chat should stay marked as unread.

Actual Result:

The chat that was opened earlier is marked as unread. Explained by @iwiznia:

I can't reliably reproduce this, but happens several times a day in web. I get a new message, I read it, come back later and the message is back to unread.

Workaround:

None needed. It's just confusing to the user to see a chat marked as unread when it was opened before.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App ✔️
Mobile Web

Version Number: 1.0.77-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

I haven't been able to reproduce this yet on my side. Will update here if I find any more information about this.

Expensify/Expensify Issue URL:

View all open jobs on Upwork

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1626078601100700

I can't reliably reproduce this, but happens several times a day in web. I get a new message, I read it, come back later and the message is back to unread.

@thienlnam

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jboniface

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Since this hasn't been reproduced, I am hesitant to post the job

@tgolen

Looks like @tgolen @stitesExpensify and @cead22 were able to reproduce this issue too 🤔 @iwiznia I know this is a long shot but I have some questions that could help me get solid repro steps:

Do you have an estimate of how much time it passes from reading the message to the unread status?
Are there other tabs opened with e.cash active? Or other devices logged in with the same account that were being used at the same time?
Does this happen with the same chat each time or are several chats affected?

@iwiznia

@iwiznia also check that you don't have policy rooms with unread messages (eg, #announce) -- Cole let me know recently that this could be another cause of 3.cash showing the unread indicator

- Do you have an estimate of how much time it passes from reading the message to the unread status? For me, it seems to happen more often when I go to the e.cash tab, sit for 1-2 seconds (and read the most recent message), then go to another tab quickly. I suspect this is the cause of the issue. - Are there other tabs opened with e.cash active? Or other devices logged in with the same account that were being used at the same time? There should only be one tab open when it's happened to me. I very rarely use mobile and web at the same time, so I don't think this would be the cause of it. - Does this happen with the same chat each time or are several chats affected? It's always one chat affected at a time, but not always the same chat, no.

…

On Mon, Jul 12, 2021 at 4:25 PM Carlos Alvarez ***@***.***> wrote: @iwiznia <https://github.com/iwiznia> also check that you don't have policy rooms with unread messages (eg, #announce) -- Cole let me know recently that this could be another cause of 3.cash showing the unread indicator — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3981 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB2VWKW3PT757XBXWKDTXNTW5ANCNFSM5AHEFDCQ> .

@iwiznia

Do you have an estimate of how much time it passes from reading the message to the unread status?

It varies, I don't think the time is a determining factor here.

Are there other tabs opened with e.cash active? Or other devices logged in with the same account that were being used at the same time?

Nope

Does this happen with the same chat each time or are several chats affected?

Same as Tim, only one at a time, but not the same one each time

@iwiznia also check that you don't have policy rooms with unread messages (eg, #announce) -- Cole let me know recently that this could be another cause of 3.cash showing the unread indicator

Already did, this is not it. If it was, then the unread would not go away when I re-read the chat

Thanks for the extra info! 🙇 No luck yet on being able to repro the issue yet. Will update if I find something.

@johnmlee101

Should I go ahead and split these assignments into two parts? One for the front-end changes in this repo and one for the back-end internal development?

@johnmlee101 can you go ahead and do this plz

@johnmlee101

@johnmlee101 can you please help with the above and split the assignments into two parts?

Sorry, just saw this update now! On it

This issue is responsible for adding the two API end points needed.
#8267

Once those endpoints exist, then we'll go ahead and come back to this issue to make sure we're properly using the new API endpoint to update the read/unread markers (which can be done externally). This step will be combined with the deprecation of the API command and we'll revisit once things are all moved over.

Put on hold pending #8267 (internal), updated title, removed Help Wanted label (don't forget to add back when take off hold)

I will be keeping this on hold as we'll be pursuing a potential high-level refactor of this logic to simplify and inevitably fix these issues as put through our proposal process.

@stitesExpensify

From @stitesExpensify 8 days ago

Web PR is on prod, unsure why it didn't get posted here, but that means this is done!

Should we take off hold? And/or, is this related to Offline First?

I think that this issue might be fixed? My PR made it so that we can never set the lastRead backwards unless manually done by the user, that should fix this issue right?

@iwiznia

Since it doesn't sound like it's easy to reliably reproduce, it's hard to test. @iwiznia any idea of this has happened to you the past week?!?! If not, I'm down to close this then reopen if/when needed

I don't know, since the unread message indicator is totally broken for me right now. Let's close, since Marc is revamping all this soon anyway

Navigation Menu

Repository navigation

[HOLD #8267] Web - Read messages are marked unread after a while #3981

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

141 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD #8267] Web - Read messages are marked unread after a while #3981

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Jul 12, 2021

MelvinBot commented on Jul 12, 2021

jboniface commented on Jul 12, 2021

isagoico commented on Jul 12, 2021

cead22 commented on Jul 12, 2021

tgolen commented on Jul 12, 2021

iwiznia commented on Jul 13, 2021

isagoico commented on Jul 13, 2021

141 remaining items

mallenexpensify commented on Feb 22, 2022

mallenexpensify commented on Mar 21, 2022

johnmlee101 commented on Mar 22, 2022

johnmlee101 commented on Mar 22, 2022

mallenexpensify commented on Mar 25, 2022

johnmlee101 commented on Mar 31, 2022

mallenexpensify commented on May 4, 2022

stitesExpensify commented on May 4, 2022

mallenexpensify commented on May 4, 2022

iwiznia commented on May 5, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions