Skip to content

[HOLD for payment 2024-04-25] [$500] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot #39831

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-25] [$500] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot#39831
Assignees
CortneyOfstadmountinyc3024tienifr
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Description

@lanitochka17
lanitochka17
opened on Apr 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log out of New Dot if logged in
  2. Log in to Old Dot
  3. Click on the Concierge icon on the bottom right

Expected Result:

After redirecting to New Dot, Concierge chat will not flicker

Actual Result:

After redirecting to New Dot, Concierge chat flickers non-stop

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bandicam.2024-04-08.17-56-01-668.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cd4a71bbd34dbd5f
  • Upwork Job ID: 1777373249826816000
  • Last Price Increase: 2024-04-15
  • Automatic offers:
    • c3024 | Reviewer | 0
    • tienifr | Contributor | 0
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 8, 2024

  2. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot
    assigned
    youssef-lr
    on Apr 8, 2024
  4. github-actions
    added
    Engineering
    HourlyKSv2
    on Apr 8, 2024

  5. github-actions commented on Apr 8, 2024

    @github-actions
    github-actionsBot
    on Apr 8, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. lanitochka17 commented on Apr 8, 2024

    @lanitochka17
    lanitochka17
    on Apr 8, 2024
    Author

    We think that this bug might be related to #wave-collect - Release 1

  7. lanitochka17 commented on Apr 8, 2024

    @lanitochka17
    lanitochka17
    on Apr 8, 2024
    Author

    @youssef-lr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  8. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 8, 2024
  9. melvin-bot
    changed the title [-]OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot[/-] [+][$250] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot[/+] on Apr 8, 2024

  10. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01cd4a71bbd34dbd5f

  11. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 8, 2024
  12. melvin-bot
    assigned
    c3024
    on Apr 8, 2024
  13. mountiny
    changed the title [-][$250] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot[/-] [+][$500] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot[/+] on Apr 8, 2024

  14. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  15. 45 remaining items

  16. mountiny
    added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Apr 16, 2024
  17. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Apr 18, 2024
  18. melvin-bot
    changed the title [-][$500] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot[/-] [+][HOLD for payment 2024-04-25] [$500] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot[/+] on Apr 18, 2024

  19. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@c3024] Determine if we should create a regression test for this bug.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  21. mountiny commented on Apr 20, 2024

    @mountiny
    mountiny
    on Apr 20, 2024
    Contributor

    I think we are good to pay this one out

  22. CortneyOfstad commented on Apr 24, 2024

    @CortneyOfstad
    CortneyOfstad
    on Apr 24, 2024
    Contributor

    Payment set for tomorrow! @c3024 can you complete the checklist by EOD, so there is no delay in issuing payment? Thanks!

  23. c3024 commented on Apr 24, 2024

    @c3024
    c3024
    on Apr 24, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Proposal

    1. Log out of New Dot if logged in
    2. Log on to Old Dot
    3. Click on the Concierge icon on the bottom right. It redirects to New Dot
    4. After redirecting to New Dot, verify that Concierge chat does not flicker continuously

    👍 or 👎

  24. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 24, 2024

  25. CortneyOfstad commented on Apr 25, 2024

    @CortneyOfstad
    CortneyOfstad
    on Apr 25, 2024
    Contributor

    Payment Summary

    @tienifr — paid $500 via Upwork
    @c3024 — paid $500 via Upwork

  26. CortneyOfstad commented on Apr 25, 2024

    @CortneyOfstad
    CortneyOfstad
    on Apr 25, 2024
    Contributor

    Regression test here — https://github.com/Expensify/Expensify/issues/390864

    Closing — thanks all!

  27. CortneyOfstad
    closed this as completedon Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions