Skip to content

[HOLD for payment 2024-04-25] [$500] Composer - Pointer returns to previous line when adding new line #39836

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to any report
  2. Write some text > 'Shift + Enter' to add new line
  3. Write some test > 'Shift + Enter' to add new line

Expected Result:

New line should remain created and pointer shouldn't return to the second link

Actual Result:

New line disappears after creation and pointer is return to the second link

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442296_1712582446951.Screen_Recording_2024-04-08_at_4.20.19_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0126b896f5a0cd6841
  • Upwork Job ID: 1777441390901157888
  • Last Price Increase: 2024-04-09
  • Automatic offers:
    • akinwale | Reviewer | 0
Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. kbecciv commented on Apr 8, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb

  4. mountiny commented on Apr 8, 2024

    @mountiny
    Contributor

    I believe this is same as the bug @mallenexpensify raised where leaving a whitespace at the end of the text goes back

    Screen.Recording.2024-04-08.at.17.34.16.mov
  5. deetergp commented on Apr 8, 2024

    @deetergp
    Contributor

    Sounds like Software Mansion is being asked to investigate this https://expensify.slack.com/archives/C06SNCPJCLT/p1712346760326019

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 8, 2024
  7. changed the title [-]Composer - Pointer returns to previous line when adding new line[/-] [+][$250] Composer - Pointer returns to previous line when adding new line[/+] on Apr 8, 2024
  8. melvin-bot commented on Apr 8, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 8, 2024
  10. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  11. 45 remaining items

  12. bfitzexpensify commented on Apr 11, 2024

    @bfitzexpensify
    Contributor

    Payments complete.

  13. akinwale commented on Apr 11, 2024

    @akinwale
    Contributor

    50% of the reward to @arjun-dureja so $250 cc @bfitzexpensify

    Same would go to @akinwale for testing the PR and checklist there

    @mountiny Just wanted to confirm if the payment due for review here is $250 or $500 since the bounty was actually raised to $500.

    Thanks.

    cc @bfitzexpensify

  14. mountiny commented on Apr 15, 2024

    @mountiny
    Contributor

    @bfitzexpensify can we please issue bonus of $250 to @akinwale to make this $500 total, thanks!

  15. mallenexpensify commented on Apr 17, 2024

    @mallenexpensify
    Contributor

    Contributor: @arjun-dureja paid $250 via Upwork
    Contributor+: @akinwale paid $500 via Upwork (an initial payment of $250 and bonus of $250)

    Happened to be subscribed so I paid the $250 as a bonus.

    @bfitzexpensify , when confirming payments in GH issues, can use the above format for all? I have a version of it saved as a TextExpander to make it easy to paste in each time. Thx

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 18, 2024
  17. changed the title [-][$500] Composer - Pointer returns to previous line when adding new line[/-] [+][HOLD for payment 2024-04-25] [$500] Composer - Pointer returns to previous line when adding new line[/+] on Apr 18, 2024
  18. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  19. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@akinwale] Determine if we should create a regression test for this bug.
    • [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions