Skip to content

[HOLD for payment 2024-04-25] [HOLD for payment 2024-04-17] [Guided Setup] [$250] Sign up - Welcome modal window on Abracadabra page #39837

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2616817
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Enter new email
  3. Copy magic link from received email
  4. Change link to stage
  5. Open link in a new tab
  6. Navigate to original tab

Expected Result:

The abracadabra page is displayed
On original tab Concierge chat opens. The 'Welcome to Expensify' modal window appears

Actual Result:

The abracadabra page is displayed. The 'Welcome to Expensify' modal window appears on abracadabra page.
On original tab the skeleton loader displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442285_1712582015558.bandicam_2024-04-08_16-05-31-752.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017ea247a272b092bf
  • Upwork Job ID: 1777419039357227008
  • Last Price Increase: 2024-04-08
  • Automatic offers:
    • hoangzinh | Contributor | 0
Issue OwnerCurrent Issue Owner: @miljakljajic

Activity

  1. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Apr 8, 2024

    @lanitochka17
    Author

    @cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. cead22 commented on Apr 8, 2024

    @cead22
    Contributor

    I think it's a regression from #37733

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Apr 8, 2024
  6. melvin-bot commented on Apr 8, 2024

    @melvin-bot
  7. changed the title [-]Sign up - Welcome modal window on Abracadabra page[/-] [+][$250] Sign up - Welcome modal window on Abracadabra page[/+] on Apr 8, 2024
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 8, 2024
  9. 51 remaining items

  10. hoangzinh commented on Apr 30, 2024

    @hoangzinh
    Contributor

    Accepted. Thanks @miljakljajic

  11. JmillsExpensify commented on Apr 30, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @mananjadhav

  12. melvin-bot commented on May 3, 2024

    @melvin-bot

    @cead22, @mananjadhav, @hoangzinh, @miljakljajic, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. mananjadhav commented on May 3, 2024

    @mananjadhav
    Collaborator

    I think we're good to close this one. @miljakljajic @mountiny

  14. hoangzinh commented on May 4, 2024

    @hoangzinh
    Contributor

    yup process payment then we're good to close this issue.

  15. cead22 commented on May 6, 2024

    @cead22
    Contributor

    Which payment is missing?

  16. miljakljajic commented on May 7, 2024

    @miljakljajic
    Contributor

    paid!

  17. hoangzinh commented on Aug 13, 2024

    @hoangzinh
    Contributor

    Hi @miljakljajic I'm just checking Upwork and it appears that my payment for this issue hasn't been completed yet. Can you check again? Thank you.

  18. miljakljajic commented on Aug 13, 2024

    @miljakljajic
    Contributor

    resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions