Repository navigation
[$250] Search - Infinite loading when searching for a non existing user #39866
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #39384
Action Performed:
- Access staging.new.expensify.com
- Sign into a valid account
- Search for a non existing user
- Once the DM is open, tap on the header
Expected Result:
User expects that when tapping on the header, the users info modal will open from the right
Actual Result:
When user first tries to tap on search modal, there is a small "Locked" symbol, then after a while, the header name will completely disappear and begin to load indefinitely. On Desktop app, the app even crashed once while performing this
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6442599_1712597864799.Infinite_loading_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01fe30a5f76eb81164
- Upwork Job ID: 1777450137396224000
- Last Price Increase: 2024-04-08
Activity
melvin-bot commentedon Apr 8, 2024
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 8, 2024
@aldo-expensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 8, 2024
We think that this bug might be related to #vip-vsp
aldo-expensify commentedon Apr 8, 2024
I can reproduce often, but doesn't always happen. And sometimes the top bar goes into loading state and the email disappears from the LHN without having to even click on it:
aldo-expensify commentedon Apr 8, 2024
Can't reproduce in Production. I'll open it to
externalas I don't see a difference in theonyxDatacoming from the server when comparing production vs staging.[-]Search - Infinite loading when searching for a non existing user[/-][+][$250] Search - Infinite loading when searching for a non existing user[/+]melvin-bot commentedon Apr 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01fe30a5f76eb81164
8 remaining items
aldo-expensify commentedon Apr 8, 2024
Seems like the personal details somehow go missing from onyx. No, the report onyx update is missing in theOpenReportresponse, so we end up with the optimistic report only which has the wrong accountIDsaldo-expensify commentedon Apr 8, 2024
I think this is a product of my work moving the OpenReport onyx updates from Web-Expensify to Auth. These two PRs:
https://github.com/Expensify/Web-Expensify/pull/41310
https://github.com/Expensify/Auth/pull/10226
That works based on the assumption that the onyx update created and queued in Auth will be automatically included in the response in PHP later, but this doesn't happen thanks to the Reliable updates check here: https://github.com/Expensify/Web-Expensify/blob/9665848765ad8df8dd478dd3a3a242a6ead62ea6/lib/Onyx.php#L368
Then, I made this third PR to kill some code I thought unnecessary https://github.com/Expensify/Web-Expensify/pull/41492. The removed code unintentionally was still adding the missing report update for accounts with reliable updates disabled.
Considering the above, this is not an App deploy blocker because the bug is in the staging PHP API.
aldo-expensify commentedon Apr 9, 2024
I merged this PR which should fix the problem once deployed: https://github.com/Expensify/Web-Expensify/pull/41588
Also, we are trying to get rid of the reliable updates beta asap, so that would have fixed it too.
alexpensify commentedon Apr 12, 2024
Aldo, I think the only action is the get rid of the beta-- is that right? Thanks!
aldo-expensify commentedon Apr 15, 2024
This is fixed now, I just tested.
alexpensify commentedon Apr 15, 2024
No payment is due here, all reviews were handled internally