Skip to content

[HOLD for payment 2024-06-06] [Guided Setup] [$250] Login - "Here is your magic code" appears briefly before the abracadabra page #39904

New issue
New issue
Closed
Closed
[HOLD for payment 2024-06-06] [Guided Setup] [$250] Login - "Here is your magic code" appears briefly before the abracadabra page#39904
Assignees
lakchoteparasharrajatbernhardojadelekennedy
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@izarutskaya
izarutskaya
opened on Apr 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.61.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481382&group_by=cases:section_id&group_id=229043&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Start logging in with a new Gmail account
  2. Copy the magic link, paste it to iCloud notes and add "staging" to it
  3. Open it from iCloud notes

Expected Result:

Only the abracadabra page should show.

Actual Result:

"Here is your magic code" appears briefly before the abracadabra page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6442666_1712601744345.WFOT6467.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01505b69dbb8511b47
  • Upwork Job ID: 1777673648903905280
  • Last Price Increase: 2024-04-09
  • Automatic offers:
    • bernhardoj | Contributor | 0
Issue OwnerCurrent Issue Owner: @lakchote

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 9, 2024
  2. melvin-bot
    assigned
    lakchote
    on Apr 9, 2024

  3. melvin-bot commented on Apr 9, 2024

    @melvin-bot
    melvin-botBot
    on Apr 9, 2024 – with Melvin Bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot
    assigned
    adelekennedy
    on Apr 9, 2024

  5. melvin-bot commented on Apr 9, 2024

    @melvin-bot
    melvin-botBot
    on Apr 9, 2024 – with Melvin Bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Apr 9, 2024

  7. github-actions commented on Apr 9, 2024

    @github-actions
    github-actionsBot
    on Apr 9, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    izarutskaya
    on Apr 9, 2024
    Author

    @adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  9. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    izarutskaya
    on Apr 9, 2024
    Author

    Production

    RPReplay_Final1712651021.MP4
  10. lakchote
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 9, 2024

  11. melvin-bot commented on Apr 9, 2024

    @melvin-bot
    melvin-botBot
    on Apr 9, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01505b69dbb8511b47

  12. 47 remaining items

  13. melvin-bot
    added
    Overdue
    on Jun 6, 2024

  14. adelekennedy commented on Jun 6, 2024

    @adelekennedy
    adelekennedy
    on Jun 6, 2024
    Contributor

    @bernhardoj payment made!

  15. melvin-bot
    removed
    Overdue
    on Jun 6, 2024

  16. parasharrajat commented on Jun 6, 2024

    @parasharrajat
    parasharrajat
    on Jun 6, 2024
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: This happens due to delay in updation of signing state.
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    • [@parasharrajat] Determine if we should create a regression test for this bug. yes
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Steps

    Test with 2FA enabled

    Web/mWeb/Desktop

    1. Log out
    2. Enter your account which has 2fa enabled login and press Next
    3. Open the magic code email
    4. Copy the magic link
    5. Append staging. to the magic link and open it on another tab
    6. Verify after the splash screen, you see a loading indicator
    7. Wait until it loads completely
    8. Verify you see the 2FA required page
    9. Verify the loading indicator isn't visible

    Test without 2FA

    Web/mWeb/Desktop

    1. Log out
    2. Enter any login and press Next
    3. Open the magic code email
    4. Copy the magic link
    5. Append staging. to the magic link and open it on another tab
    6. Verify after the splash screen, you see a loading indicator
    7. Wait until it loads completely
    8. Verify you see the Abracadabra page

    Do you agree 👍 or 👎 ?

  17. adelekennedy commented on Jun 7, 2024

    @adelekennedy
    adelekennedy
    on Jun 7, 2024
    Contributor

    Payouts due:

    Upwork job is here.

  18. adelekennedy commented on Jun 7, 2024

    @adelekennedy
    adelekennedy
    on Jun 7, 2024
    Contributor

    @lakchote to review the regression test steps above!

  19. melvin-bot
    added
    Overdue
    on Jun 10, 2024

  20. melvin-bot commented on Jun 10, 2024

    @melvin-bot
    melvin-botBot
    on Jun 10, 2024 – with Melvin Bot

    @lakchote, @parasharrajat, @bernhardoj, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  21. melvin-bot commented on Jun 12, 2024

    @melvin-bot
    melvin-botBot
    on Jun 12, 2024 – with Melvin Bot

    @lakchote, @parasharrajat, @bernhardoj, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

  22. adelekennedy commented on Jun 13, 2024

    @adelekennedy
    adelekennedy
    on Jun 13, 2024
    Contributor

    I completely forgot @lakchote is on parental leave - I think the regression steps make sense so moving forward with creating the GH

  23. adelekennedy
    closed this as completedon Jun 13, 2024
  24. melvin-bot
    removed
    Overdue
    on Jun 14, 2024
  25. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Jun 14, 2024

  26. parasharrajat commented on Jun 14, 2024

    @parasharrajat
    parasharrajat
    on Jun 14, 2024
    Member

    Payment requested as per #39904 (comment)

  27. JmillsExpensify commented on Jun 17, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jun 17, 2024
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions