[HOLD for payment 2024-05-02] Investigate Search, SignInpage and ReportScreen flaky perf tests

Problem

We have noticed recently that some of the SearchPage and SignInPage reassure tests are being flaky. Slack thread.

There is also a ReportScreen test flaky https://expensify.slack.com/archives/C01GTK53T8Q/p1712676878465949?thread_ts=1712669146.879679&cid=C01GTK53T8Q [ReportScreen] should press of the report item

This could have happened after some refactoring of the lower level components, implementing some caching mechanism for example.

This is a problem as its undermining the reliability of the tests.

Solution

Investigate the flakiness and make sure the tests are robust again.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0130b2a9f98f63ea9f
Upwork Job ID: 1783652764398231552
Last Price Increase: 2024-04-26

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Hi! I'm Olimpia from Callstack. I want to work on this issue.

@OlimpiaZurek

@OlimpiaZurek how is this looking?

@mountiny

@mountiny I have prepared a PR with refactored tests and we are discussing these changes internally. In this PR, I removed the SignInPage tests and moved them down the component tree, but I'm wondering if they should be removed completely. SingInPage is not part of the audit and catching regressions is not important in this part of the UI. Also removing this will also reduce the time taken by Reassure.

@mountiny

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@OlimpiaZurek] Determine if we should create a regression test for this bug.
[@OlimpiaZurek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Job added to Upwork: https://www.upwork.com/jobs/~0130b2a9f98f63ea9f

@Pujan92

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Pujan92 (Internal)

@hungvu193

Added @hungvu193 as C+ since he reviewed the PR.

@hungvu193

Sent offer to @hungvu193 https://www.upwork.com/nx/wm/offer/102036441

Moving to daily since payment is tomorrow.

All paid, thanks everyone

Navigation Menu

Repository navigation

[HOLD for payment 2024-05-02] Investigate Search, SignInpage and ReportScreen flaky perf tests #39913

Problem

Solution

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-05-02] Investigate Search, SignInpage and ReportScreen flaky perf tests #39913

Description

Problem

Solution

Activity

melvin-bot commented on Apr 9, 2024

OlimpiaZurek commented on Apr 9, 2024

mountiny commented on Apr 16, 2024

OlimpiaZurek commented on Apr 16, 2024

22 remaining items

melvin-bot commented on Apr 25, 2024

melvin-bot commented on Apr 26, 2024

melvin-bot commented on Apr 26, 2024

sakluger commented on Apr 26, 2024

sakluger commented on Apr 26, 2024

sakluger commented on May 1, 2024

sakluger commented on May 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions