Skip to content

[Simplified Collect: Tags] Tags - "Required" text is missing for required tags #39916

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #37388
Email or phone of affected tester (no customers): applausetester+omemploy33@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  1. Setup collect policy in OD for Tags and Categories and invite employee account to created policy
  2. Enable "People must tag expenses"
  3. Enable multilevel tags in OD
  4. Create or import two or more multi-level tags
  5. Disable toggle "REQUIRED" for half multilevel tags

Steps:

  1. Open https://staging.new.expensify.com/

  2. Sign In with employee account

  3. Navigate to Workspace chat

  4. Tap on plus button

  5. Select Manual tab

  6. Write any amount and click on Continue button

  7. Click on Show more

  8. Scroll down to multilevel tags

Expected Result:

"Requered" text should be displayed in ND against required tags

Actual Result:

"Required" text is missing for required tags in RHP in ND when required option enabled in OD

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6442492_1712592413899.Screen_Recording_2024-04-08_at_19.04.01.mp4

Independent - Multi Level tags.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01748ca53197beb1a7
  • Upwork Job ID: 1785471332084727808
  • Last Price Increase: 2024-05-08
Issue OwnerCurrent Issue Owner: @gijoe0295

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2024
  2. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    Author

    @mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    Author

    Production

    20240409_180811.mp4
  8. 99 remaining items

  9. gijoe0295 commented on Jun 18, 2024

    @gijoe0295
    Contributor

    Thanks. Since this fix is purely in the BE and I don't have access, I think the second option made more sense.

    The other option is for @carlosmiceli to comment if they specifically reviewed and used your code. If so, @carlosmiceli should propose the compensation percentage they feel is fair (100,50,25%)

    cc @carlosmiceli for help. Do you think my proposal assisted your investigation?

  10. carlosmiceli commented on Jun 19, 2024

    @carlosmiceli
    Contributor

    I think the investigation was not related to the implementation but it did help us skip looking into the FE for problems, so I think 25% compensation is fair. cc @mallenexpensify

  11. mvtglobally commented on Jul 3, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  12. carlosmiceli commented on Jul 3, 2024

    @carlosmiceli
    Contributor

    @mallenexpensify think we can close this one?

  13. mallenexpensify commented on Jul 5, 2024

    @mallenexpensify
    Contributor

    @gijoe0295 can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~018e0cc7dd6abb5f54

  14. mvtglobally commented on Jul 19, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  15. gijoe0295 commented on Jul 19, 2024

    @gijoe0295
    Contributor

    I accepted the offer.

  16. mallenexpensify commented on Jul 22, 2024

    @mallenexpensify
    Contributor

    Contributor: @gijoe0295 paid $75 via Upwork

    Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHot PickReady for an engineer to pick up and run withInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions