Skip to content

[Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal #39932

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481382&group_by=cases:section_id&group_id=229043&group_order=asc
Issue reported by: Applause - Internal Team

Action Performed:

  1. Start logging in with a new Gmail account
  2. Copy the magic link, paste it to iCloud notes and add "staging" to it
  3. Open it from iCloud notes
  4. Switch back to the first tab

Expected Result:

"Welcome to Expensify" modal should appear

There should be Concierge chat in the LHN

Actual Result:

"Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442656_1712601054217.WFOT6467.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bb9b4c17e55d927b
  • Upwork Job ID: 1777819519501967360
  • Last Price Increase: 2024-05-04

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 9, 2024
  2. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. lanitochka17 commented on Apr 9, 2024

    @lanitochka17
    Author

    @trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. trjExpensify commented on Apr 9, 2024

    @trjExpensify
    Contributor

    @tienifr @DylanDylann this is in the regression period. Can you take a look?

  5. tienifr commented on Apr 9, 2024

    @tienifr
    Contributor

    Checking.

  6. tienifr commented on Apr 9, 2024

    @tienifr
    Contributor

    I don't think this is related to my PR. The empty UI and welcome modal is completely different. So the empty UI would never block the welcome modal from display. I think the root cause is that the welcome modal hasn't covered the case when user logged in using magic deep link.

    Also on first login, Concierge chat should always show but in this case it doesn't. It seems like another issue.

    So the correct issue for this is: Welcome modal does not show on login using magic deep link.

  7. tienifr commented on Apr 9, 2024

    @tienifr
    Contributor

    I think we should tag the author of onboarding flow or the welcome modal here to take a look.

  8. trjExpensify commented on Apr 9, 2024

    @trjExpensify
    Contributor

    Cool, have done here. CC: @mountiny

  9. self-assigned this
    on Apr 9, 2024
  10. mountiny commented on Apr 9, 2024

    @mountiny
    Contributor

    asking QA to retest if its not deploy blocker actually

  11. mountiny commented on Apr 9, 2024

    @mountiny
    Contributor

    QA confirmed this is not deploy blocker. I feel like we can do nothing here and just focus on getting the stage1 onboarding done asap

  12. 28 remaining items

  13. changed the title [-][Hold PR #39687] [Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal[/-] [+][Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal[/+] on Apr 27, 2024
  14. melvin-bot commented on Apr 27, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. mountiny commented on Apr 29, 2024

    @mountiny
    Contributor

    Is this still reproducible @alitoshmatov @lanitochka17 ?

  16. melvin-bot commented on May 3, 2024

    @melvin-bot

    @trjExpensify, @mountiny, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. melvin-bot commented on May 4, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  18. mvtglobally commented on May 6, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  19. melvin-bot commented on May 7, 2024

    @melvin-bot

    @trjExpensify @mountiny @alitoshmatov this issue is now 4 weeks old, please consider:

    • Finding a contributor to fix the bug
    • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  20. melvin-bot commented on May 7, 2024

    @melvin-bot

    @trjExpensify, @mountiny, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  21. trjExpensify commented on May 7, 2024

    @trjExpensify
    Contributor

    Issue is no longer reproducible, closing Melv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions