You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal #39932
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
I don't think this is related to my PR. The empty UI and welcome modal is completely different. So the empty UI would never block the welcome modal from display. I think the root cause is that the welcome modal hasn't covered the case when user logged in using magic deep link.
Also on first login, Concierge chat should always show but in this case it doesn't. It seems like another issue.
So the correct issue for this is: Welcome modal does not show on login using magic deep link.
changed the title [-][Hold PR #39687] [Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal[/-][+][Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal[/+]on Apr 27, 2024
Activity
melvin-bot commentedon Apr 9, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Apr 9, 2024
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
trjExpensify commentedon Apr 9, 2024
@tienifr @DylanDylann this is in the regression period. Can you take a look?
tienifr commentedon Apr 9, 2024
Checking.
tienifr commentedon Apr 9, 2024
I don't think this is related to my PR. The empty UI and welcome modal is completely different. So the empty UI would never block the welcome modal from display. I think the root cause is that the welcome modal hasn't covered the case when user logged in using magic deep link.
Also on first login, Concierge chat should always show but in this case it doesn't. It seems like another issue.
So the correct issue for this is: Welcome modal does not show on login using magic deep link.
tienifr commentedon Apr 9, 2024
I think we should tag the author of onboarding flow or the welcome modal here to take a look.
trjExpensify commentedon Apr 9, 2024
Cool, have done here. CC: @mountiny
mountiny commentedon Apr 9, 2024
asking QA to retest if its not deploy blocker actually
mountiny commentedon Apr 9, 2024
QA confirmed this is not deploy blocker. I feel like we can do nothing here and just focus on getting the stage1 onboarding done asap
28 remaining items
[-][Hold PR #39687] [Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal[/-][+][Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal[/+]melvin-bot commentedon Apr 27, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
mountiny commentedon Apr 29, 2024
Is this still reproducible @alitoshmatov @lanitochka17 ?
melvin-bot commentedon May 3, 2024
@trjExpensify, @mountiny, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon May 4, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
mvtglobally commentedon May 6, 2024
Issue not reproducible during KI retests. (First week)
melvin-bot commentedon May 7, 2024
@trjExpensify @mountiny @alitoshmatov this issue is now 4 weeks old, please consider:
Thanks!
melvin-bot commentedon May 7, 2024
@trjExpensify, @mountiny, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
trjExpensify commentedon May 7, 2024
Issue is no longer reproducible, closing Melv.