Skip to content

Clean up the getOutstandingChildRequest logic to match holistically what is in backend #39953

Closed

Description

@mountiny

The getOutstandingChildRequest logic is used to determine if the chat should have GBR in relation to money request. There is many cases this can work so we should make sure we correctly handle this optimistically.

I will try to clean this up to match the backend logic as much as possible to avoid any flashing of the GBR

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f7e94d9a1d232c0e
  • Upwork Job ID: 1777725361246265344
  • Last Price Increase: 2024-04-09
Issue OwnerCurrent Issue Owner: @mountiny

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 9, 2024
  2. self-assigned this
    on Apr 9, 2024
  3. melvin-bot commented on Apr 9, 2024

    @melvin-bot
  4. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

  5. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. added and removed on Apr 9, 2024
  7. mountiny commented on Apr 9, 2024

    @mountiny
    ContributorAuthor

    Making ths weekly now as I am not sure I will get to this tomorrow and then I am ooo

  8. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 23, 2024
  9. 58 remaining items

  10. mountiny commented on Apr 14, 2025

    @mountiny
    ContributorAuthor

    Low

  11. mountiny commented on May 16, 2025

    @mountiny
    ContributorAuthor

    low

  12. mountiny commented on Jun 18, 2025

    @mountiny
    ContributorAuthor

    still low

  13. mountiny commented on Jul 23, 2025

    @mountiny
    ContributorAuthor

    I will close this one in favour of the audit of GBR as this should be handled as part of it and does not make that much sense to dig into just this one piece individually now #66716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions