[HOLD for payment 2024-06-06] [$250] Implement offline behavior and error handling for UpdateGroupChatName

@jliexpensify

Similar to #39983

We are now able to add a custom Group chat name. However, we do not handle any failure case yet.

Let's take whatever we are doing for the update "workspace room" name flow and apply the same error handling here.

In the backend, we currently send exceptions like this:

Onyx::handleException($e, 'AD9240FD-A780-425D-B98D-96DD6E4251C1', OnyxKeys::COLLECTION_REPORT.$reportID, ['errorFields', 'reportName']);

Which will put an error field on the report if updating the name fails.

We need that error to lead the user back to the "Settings" > "Name" field (RBR) and display an error message back to the user.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0128ec154dad5b4df3
Upwork Job ID: 1786226453820362752
Last Price Increase: 2024-05-03
Automatic offers:

dukenv0307 | Reviewer | 0
nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @jliexpensify

Cases to check (not limited to):

The value that we validate vs. the value that we send to the BE are different (one is trimmed the other is not)
Is the limit 255 or 256 (isValidReportName uses 255 while maxLength uses 256)
See if we can remove isValidReportName function (maxLength prop should be enough)
Clear error after trying to set a new name

Screen.Recording.2024-04-11.at.8.47.27.AM.mov

This can come off HOLD now

On looking some more I am not sure if we need any BE change for this. This is the only check we have that might throw...

So, in reality the BE is more restrictive than the frontend atm. But I think that is fine.

Let's just update the frontend and make sure we handle any possible error (though I'm not sure what that would be really besides user losing access to the report - and that is quite rare).

@jliexpensify

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@dukenv0307

@dukenv0307 The PR is here.

Reviewing label has been removed, please complete the "BugZero Checklist".

@dukenv0307

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Implement offline behavior and error handling for UpdateGroupChatName #41826

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

@dukenv0307 requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)

@dukenv0307

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@nkdengineer

Payment Summary

C: @nkdengineer $250
C+: @dukenv0307 $250

Upwork job

Just waiting on the checklist

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test:

Create a group
Go to force offline mode
Try to edit group name with an invalid name (example: adoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoaỏ)
Verify that: group name in Settings is grayed out
Back to online mode
Verify that: group name returns back and the error message appears

Do we 👍 or 👎

That sounds like a good test case to me 👍

Paid, job closed. Thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-06] [$250] Implement offline behavior and error handling for `UpdateGroupChatName` #39984

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-06-06] [$250] Implement offline behavior and error handling for UpdateGroupChatName #39984

Description

Activity

s77rt commented on Apr 11, 2024

marcaaron commented on May 3, 2024

marcaaron commented on May 3, 2024

melvin-bot commented on May 3, 2024

melvin-bot commented on May 3, 2024

23 remaining items

nkdengineer commented on May 9, 2024

melvin-bot commented on May 30, 2024

melvin-bot commented on May 30, 2024

melvin-bot commented on May 30, 2024

jliexpensify commented on May 31, 2024

dukenv0307 commented on May 31, 2024

marcaaron commented on May 31, 2024

jliexpensify commented on Jun 6, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[HOLD for payment 2024-06-06] [$250] Implement offline behavior and error handling for `UpdateGroupChatName` #39984