Repository navigation
[Awaiting payment][$125] Web - Workspace - Console error shows up when clicking Share button #40086
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
- Go to staging.new.expensify.com
- Go to Profile > Workspaces > any workspace.
- Go to Profile.
- Click Share.
Expected Result:
No console error will show up.
Actual Result:
Console error shows up.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6445447_1712813581910.bandicam_2024-04-11_13-30-47-374.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01e680ef6d1ff9d76b
- Upwork Job ID: 1782410601436565504
- Last Price Increase: 2024-04-22
- Automatic offers:
- shubham1206agra | Reviewer | 0
- tienifr | Contributor | 0
Activity
melvin-bot commentedon Apr 11, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 11, 2024
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 11, 2024
@johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 11, 2024
We think this issue might be related to the #collect project.
izarutskaya commentedon Apr 11, 2024
Production
bandicam.2024-04-11.10-54-53-331.mp4
tienifr commentedon Apr 11, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Console error shows up.
What is the root cause of that problem?
We're setting
qrCodeSizewith default value is 0App/src/components/QRShare/index.tsx
Line 19 in 260a7de
that cause the
logoSizeis 0App/src/components/QRCode.tsx
Line 53 in 260a7de
If the logoSize is 0, the
logoBackgroundBorderRadiuswill be NaN hereWhat changes do you think we should make in order to solve the problem?
We should set the default value of
qrCodeSizeis undefined here, so thesizewill be set to 120App/src/components/QRCode.tsx
Line 44 in 260a7de
What alternative solutions did you explore? (Optional)
in
QRCode:Solution 1: Return null if size is 0
Solution 2: We can consider to fallback the size to 120 if it's 0
Solution 3: Update this line to
logoSize={(size * logoRatio) || 1}Result
web-resize.mp4
47 remaining items
[-][$125] Web - Workspace - Console error shows up when clicking Share button[/-][+][Awaiting payment][$125] Web - Workspace - Console error shows up when clicking Share button[/+]johncschuster commentedon May 21, 2024
Looking now
johncschuster commentedon May 21, 2024
@shubham1206agra it looks like you haven't accepted the invite to the job on Upwork. Can you please accept that?
johncschuster commentedon May 21, 2024
I've issued payment to @tienifr 🎉
shubham1206agra commentedon May 22, 2024
@johncschuster Offer accepted
johncschuster commentedon May 28, 2024
Payment has been issued to @shubham1206agra. Thanks for your contributions!