Task - Infinite skeleton loader when creating a task with a VOIP assignee #40103

Activity

1. kbecciv

   added

   DailyKSv2KSv2

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   on Apr 11, 2024
2. melvin-bot

   assigned

   laurenreidexpensify

   on Apr 11, 2024
3. melvin-bot commented on Apr 11, 2024

   

   melvin-botBot

   on Apr 11, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
4. kbecciv commented on Apr 11, 2024

   

   kbecciv

   on Apr 11, 2024

   Author

   More actions

   We think that this bug might be related to #vip-vsb
5. kbecciv commented on Apr 11, 2024

   

   kbecciv

   on Apr 11, 2024

   Author

   More actions

   @laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
6. nkdengineer commented on Apr 11, 2024

   

   nkdengineer

   on Apr 11, 2024

   Last edited by nkdengineer

   Contributor

   More actions

   Proposal

   Please re-state the problem that we are trying to solve in this issue.

   Infinite skeleton loader when creating a task with a VOIP assignee.

   What is the root cause of that problem?

   We clear the report in faliureData here so when the task isn't created the report show skeleton.

   App/src/libs/ReportUtils.ts

   Lines 5145 to 5150 in 7d19f82

   	{
   	onyxMethod: Onyx.METHOD.SET,
   	key: `${ONYXKEYS.COLLECTION.REPORT}${assigneeChatReportID}`,
   	value: null,
   	},
   	{

   What changes do you think we should make in order to solve the problem?

   1. We should generate an error for createdChat instead of clearing the chat report in failureData. Or back-end should also return the createChat error for chatReport in CreateTask API as well.

   2. We also shouldn't clear the optimistic personal detail because now we keep the report data, the skeleton will display in header when the request is fail. We should keep the optimistic personal detail to fix this as well and then when we clear the report, we already have the logic to clear optimistic personal detail in deleteReport function.

   failureData.push(
       {
           onyxMethod: Onyx.METHOD.MERGE,
           key: `${ONYXKEYS.COLLECTION.REPORT}${assigneeChatReportID}`,
           value: {
               errorFields: {
                   createChat: {
                       0: ...// error create chat here
                   }
               }
           },
       },
   );
   

   App/src/libs/ReportUtils.ts

   Lines 5145 to 5159 in 7d19f82

   	{
   	onyxMethod: Onyx.METHOD.SET,
   	key: `${ONYXKEYS.COLLECTION.REPORT}${assigneeChatReportID}`,
   	value: null,
   	},
   	{
   	onyxMethod: Onyx.METHOD.MERGE,
   	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${assigneeChatReportID}`,
   	value: {[optimisticChatCreatedReportAction.reportActionID]: {pendingAction: null}},
   	},
   	// If we failed, we want to remove the optimistic personal details as it was likely due to an invalid login
   	{
   	onyxMethod: Onyx.METHOD.MERGE,
   	key: ONYXKEYS.PERSONAL_DETAILS_LIST,
   	value: {

   OPTIONAL: We also can keep the task report in failureData and generate the error as well.

   What alternative solutions did you explore? (Optional)

   NA
7. laurenreidexpensify commented on Apr 12, 2024

   

   laurenreidexpensify

   on Apr 12, 2024

   Contributor

   More actions

   This doesn't seem a high value bug to fix given tasks + VOIP assignment are likely an edge case at this point in development. Am closing.
8. laurenreidexpensify

   closed this as completedon Apr 12, 2024