Skip to content

[HOLD for payment 2024-05-20] iOS - Wallet - Missing up and down key and Done button in the header of account selection list #40126

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.62-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to Profile > Wallet
  3. Add a personal bank account
  4. After returning to ND from Plaid, note the header in account selection list

Expected Result:

There will be up and down button and the word "Done" in the header in account selection list (screenshot from 1.4.61-8)

Actual Result:

The header in account selection list is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445965_1712846010759.RPReplay_Final1712845359.mp4

Bug6445965_1712846010774!1 4 62-3

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kevinksullivan

Activity

  1. melvin-bot commented on Apr 11, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Apr 11, 2024

    @lanitochka17
    Author

    @luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Apr 11, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Выпуск 1

  5. lanitochka17 commented on Apr 11, 2024

    @lanitochka17
    Author

    Production:

    RPReplay_Final1712850391.MP4
  6. luacmartins commented on Apr 11, 2024

    @luacmartins
    Contributor

    I think we can demote this to NAB and make it external, since the functionality is not broken.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 11, 2024
  8. 57 remaining items

  9. melvin-bot commented on May 20, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @MrMuzyk is from an agency-contributor and not due payment
    • Reviewer: @thesahindia owed $250 via NewDot

    BugZero Checklist (@kevinksullivan)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. kevinksullivan commented on May 21, 2024

    @kevinksullivan
    Contributor

    Confirmed summary is accurate. @thesahindia can you finish out the checklist above?

  11. thesahindia commented on May 24, 2024

    @thesahindia
    Member

    Not a regression. It was a minor issue and we don't need a test case for this.

  12. melvin-bot commented on May 27, 2024

    @melvin-bot

    @luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

  13. JmillsExpensify commented on May 31, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @thesahindia

  14. melvin-bot commented on May 31, 2024

    @melvin-bot

    @luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  15. luacmartins commented on Jun 3, 2024

    @luacmartins
    Contributor

    Are we good to close this one?

  16. thesahindia commented on Jun 4, 2024

    @thesahindia
    Member

    Yeah, we can close this.

  17. luacmartins commented on Jun 4, 2024

    @luacmartins
    Contributor

    Awesome! Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions