Skip to content

[HOLD for payment 2024-04-25] Split option is showing up in the Send money flow #40242

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-25] Split option is showing up in the Send money flow#40242
Assignees
trjExpensifymountinyshubham1206agra
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Description

@mountiny
mountiny
opened on Apr 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.62-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation:

Action Performed:

Break down in numbered steps

  1. In Global Create > Send Money
  2. Choose Amount
  3. On participants page, notice there is Split option next to the name

Expected Result:

Describe what you think should've happened

In send money flow there should be no split option

Actual Result:

Describe what actually happened

There is option to split in send money flow

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Activity

  1. mountiny
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 15, 2024
  2. mountiny
    assigned
    mountiny
    and
    shubham1206agra
    on Apr 15, 2024
  3. melvin-bot
    assigned
    trjExpensify
    on Apr 15, 2024

  4. melvin-bot commented on Apr 15, 2024

    @melvin-bot
    melvin-botBot
    on Apr 15, 2024 – with Melvin Bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. mountiny
    added
    ReviewingHas a PR in review
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 15, 2024

  6. melvin-bot commented on Apr 15, 2024

    @melvin-bot
    melvin-botBot
    on Apr 15, 2024 – with Melvin Bot

    Current assignee @mountiny is eligible for the DeployBlockerCash assigner, not assigning anyone new.

  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Apr 15, 2024

  8. mountiny commented on Apr 15, 2024

    @mountiny
    mountiny
    on Apr 15, 2024
    ContributorAuthor

    This is coming from #39190

  9. github-actions commented on Apr 15, 2024

    @github-actions
    github-actionsBot
    on Apr 15, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  10. mountiny
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Apr 15, 2024

  11. mountiny commented on Apr 15, 2024

    @mountiny
    mountiny
    on Apr 15, 2024
    ContributorAuthor

    CPed to staging

  12. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    DailyKSv2
    on Apr 18, 2024
  13. melvin-bot
    changed the title [-]Split option is showing up in the Send money flow[/-] [+][HOLD for payment 2024-04-25] Split option is showing up in the Send money flow[/+] on Apr 18, 2024

  14. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Apr 18, 2024

  16. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
    • [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@shubham1206agra] Determine if we should create a regression test for this bug.
    • [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  18. shubham1206agra commented on Apr 18, 2024

    @shubham1206agra
    shubham1206agra
    on Apr 18, 2024
    Contributor

    @mountiny You can close this. No payment required here.

  19. mountiny
    closed this as completedon Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions