[HOLD for payment 2024-05-20] [$250] Skeleton loader uses lighter color for page header

@shawnborton

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.62-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713166267469379

Action Performed:

Open a chat which will show a skeleton loader
Look at the header of the chat report

Expected Result:

The skeleton loader for the top page/chat header should use the same color background as the skeleton loader for the chat messages in the main content screen.

Actual Result:

The skeleton loader used in the top page/chat header is using slightly lighter colors

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0199d049e1997c5cb7
Upwork Job ID: 1779899140122308608
Last Price Increase: 2024-04-15
Automatic offers:

abdulrahuman5196 | Reviewer | 0
GandalfGwaihir | Contributor | 0

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Loading lines colour of header and report doesn't match

What is the root cause of that problem?

Currently we have the lines colour as theme.highlightBG this gives us faint lines

App/src/components/ReportHeaderSkeletonView.tsx

Lines 47 to 53 in 1cb6e00

    
           <SkeletonViewContentLoader 
        
               animate={shouldAnimate} 
        
               width={styles.w100.width} 
        
               height={height} 
        
               backgroundColor={theme.highlightBG} 
        
               foregroundColor={theme.border} 
        
           >

What changes do you think we should make in order to solve the problem?

We need to use skeletonLHNIn as bg colour and theme.skeletonLHNOut as foreground colour.

We do the same for report screen:

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.tsx

Lines 18 to 24 in 1cb6e00

    
           <SkeletonViewContentLoader 
        
               animate={shouldAnimate} 
        
               height={CONST.CHAT_SKELETON_VIEW.HEIGHT_FOR_ROW_COUNT[numberOfRows]} 
        
               backgroundColor={theme.skeletonLHNIn} 
        
               foregroundColor={theme.skeletonLHNOut} 
        
               style={styles.mr5} 
        
           >

The colour of these styles for dark mode is :

App/src/styles/theme/themes/dark.ts

Lines 85 to 86 in 1cb6e00

    
           skeletonLHNIn: colors.productDark400, 
        
           skeletonLHNOut: colors.productDark600,

And for light mode is:

App/src/styles/theme/themes/light.ts

Lines 85 to 86 in 1cb6e00

    
           skeletonLHNIn: colors.productLight400, 
        
           skeletonLHNOut: colors.productLight600,

This should make both the report as well as the report header consistent in loading colour

What alternative solutions did you explore? (Optional)

@shawnborton

Ahh:

Issue reported by: @shawnborton

Gonna make external.

Job added to Upwork: https://www.upwork.com/jobs/~0199d049e1997c5cb7

@abdulrahuman5196

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

I was too slow in posting a proposal. 🐌

I was too slow in posting a proposal. 🐌

😆 godspeed

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton loader uses lighter color for page header.

What is the root cause of that problem?

On the hedare we are using ReportHeaderSkeletonView for the loading animation
But on the report we use ReportActionsSkeletonView

Those boath components uses the same SkeletonViewContentLoader with different parameters
here:

App/src/components/ReportHeaderSkeletonView.tsx

Lines 47 to 52 in fdae0bd

    
           <SkeletonViewContentLoader 
        
               animate={shouldAnimate} 
        
               width={styles.w100.width} 
        
               height={height} 
        
               backgroundColor={theme.highlightBG} 
        
               foregroundColor={theme.border}

and here:

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.tsx

Lines 18 to 23 in fdae0bd

    
           <SkeletonViewContentLoader 
        
               animate={shouldAnimate} 
        
               height={CONST.CHAT_SKELETON_VIEW.HEIGHT_FOR_ROW_COUNT[numberOfRows]} 
        
               backgroundColor={theme.skeletonLHNIn} 
        
               foregroundColor={theme.skeletonLHNOut} 
        
               style={styles.mr5}

Also there's an issue with the alignment of the animation

What changes do you think we should make in order to solve the problem?

1- to fix the colors:
we shoudl use the same backgroundColor and foregroundColor

backgroundColor={theme.skeletonLHNIn}
foregroundColor={theme.skeletonLHNOut}

2- align the header animation same as report animation
we should remove the padding left here

App/src/components/ReportHeaderSkeletonView.tsx

Line 33 in fdae0bd

    
           <View style={[styles.appContentHeaderTitle, !isSmallScreenWidth && styles.pl5]}>

POC:

@marcochavezf

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@marcaaron

~~Friendly bump for PR review @marcaaron~~

@marcochavezf

friendly bump @marcochavezf for PR review

Reviewing label has been removed, please complete the "BugZero Checklist".

@abdulrahuman5196

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Fix]: Foreground and Background of report header don't match with report view loading state #40534

If no regressions arise, payment will be issued on 2024-05-20. 🎊

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment automatic offer (Reviewer)
@GandalfGwaihir requires payment automatic offer (Contributor)

@abdulrahuman5196

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@abdulrahuman5196

Payment Summary:

@abdulrahuman5196 paid $250 here (Reviewer)
@GandalfGwaihir paid $250 here (Contributor)

I dont' think this was actually an introduced bug right, but it was actually a new feature. It never looked this way before right? We just got our greys wrong originally. I'm also not sure we can do regression testing for this?

Navigation Menu

Repository navigation

[HOLD for payment 2024-05-20] [$250] Skeleton loader uses lighter color for page header #40244

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

40 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<SkeletonViewContentLoader
	animate={shouldAnimate}
	width={styles.w100.width}
	height={height}
	backgroundColor={theme.highlightBG}
	foregroundColor={theme.border}
	>

	<SkeletonViewContentLoader
	animate={shouldAnimate}
	height={CONST.CHAT_SKELETON_VIEW.HEIGHT_FOR_ROW_COUNT[numberOfRows]}
	backgroundColor={theme.skeletonLHNIn}
	foregroundColor={theme.skeletonLHNOut}
	style={styles.mr5}
	>

	skeletonLHNIn: colors.productDark400,
	skeletonLHNOut: colors.productDark600,

	skeletonLHNIn: colors.productLight400,
	skeletonLHNOut: colors.productLight600,

[HOLD for payment 2024-05-20] [$250] Skeleton loader uses lighter color for page header #40244

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 15, 2024

allgandalf commented on Apr 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

twisterdotcom commented on Apr 15, 2024

melvin-bot commented on Apr 15, 2024

melvin-bot commented on Apr 15, 2024

mananjadhav commented on Apr 15, 2024

allgandalf commented on Apr 15, 2024

dragnoir commented on Apr 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

40 remaining items

melvin-bot commented on Apr 29, 2024

allgandalf commented on May 3, 2024

allgandalf commented on May 6, 2024

melvin-bot commented on May 13, 2024

melvin-bot commented on May 13, 2024

melvin-bot commented on May 13, 2024

twisterdotcom commented on May 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions