Repository navigation
CRITICAL: [Actionable Whispers] The report total is negative when converting a tracked expense to request #40266
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
Note: This occurs as part of a feature from this PR
Break down in numbered steps
- Track an expense to the self-DM
- Convert it to a request on an IOU that already has an existing IOU
Expected Result:
The reportPreview should show correct amount owed
Actual Result:
The reportPreview shows negative amount owed
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ebe41f88ebb9d14a
- Upwork Job ID: 1780061708144013312
- Last Price Increase: 2024-04-16
Activity
melvin-bot commentedon Apr 16, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ebe41f88ebb9d14a
melvin-bot commentedon Apr 16, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (
Internal)melvin-bot commentedon Apr 16, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thienlnam commentedon Apr 18, 2024
Seems like a BE issue
[-][Track Expense] The report total is negative when converting a tracked expense to request[/-][+]CRITICAL: [Actionable Whispers] The report total is negative when converting a tracked expense to request[/+]8 remaining items
thienlnam commentedon May 6, 2024
This is still happening when converting tracked expenses to requests on an IOU with existing requests - https://expensify.slack.com/archives/C03U7DCU4/p1715000997219589
cc @shawnborton / @dannymcclain
thienlnam commentedon May 8, 2024
Found the issue - it relies with how we handle the amount negative values for IOUs depending on who is the owner of the IOU. Working on it here https://github.com/Expensify/Auth/pull/10798
thienlnam commentedon May 8, 2024
Fix is in review
thienlnam commentedon May 13, 2024
Merged - pending deploy
melvin-bot commentedon May 21, 2024
@sobitneupane, @thienlnam, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon May 23, 2024
@sobitneupane, @thienlnam, @bfitzexpensify Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon May 27, 2024
@sobitneupane, @thienlnam, @bfitzexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
thienlnam commentedon May 28, 2024
We're done here!