[HOLD for payment 2024-06-05] [$250] Chat - Text with attachment message can be edited when the attachment is uploading

@MitchExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to staging.new.expensify.com
Go to chat.
Copy an image (from any source).
Enter text in the composer.
Paste the image via CMD+V.
Send the attachment together with the text.
While the attachment is uploading, right click on the message > Edit comment.
Edit the comment and save it.

Expected Result:

In Step 7, app should prevent comment to be editable when the attachment is uploading.

Actual Result:

In Step 7, app allows editing when the attachment with text is uploading.
As a result, the attachment is not uploaded and becomes "Uploading attachment..." when editing and saving the comment (Step 8).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6453282_1713425265582.text_and_attachment.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016d10a063fea0e0dc
Upwork Job ID: 1780928057418211328
Last Price Increase: 2024-04-25
Automatic offers:

FitseTLT | Contributor | 0

Issue Owner

Current Issue Owner: @MitchExpensify

@MariaHCD

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@MitchExpensify

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@MitchExpensify

@MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

Production

bandicam.2024-04-18.10-50-01-227.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text with attachment message can be edited when the attachment is uploading #

What is the root cause of that problem?

Here, isAttachment will be false. That's why we can see the edit icon for comments that have text and attachments.

App/src/libs/ReportActionsUtils.ts

Line 845 in 3ec8f2f

return reportAction?.isAttachment ?? !!reportAction?.attachmentInfo ?? false;

What changes do you think we should make in order to solve the problem?

We can set isAttachment to true in reportAction for cases like these.
Or we can simply check if reportAction.attachmentInfo is true. We can do something like this

reportAction?.attachmentInfo !== undefined

App/src/libs/ReportActionsUtils.ts

Line 845 in 3ec8f2f

return reportAction?.isAttachment ?? !!reportAction?.attachmentInfo ?? false;

3. We can create a new utility function hasAttachment for cases like these.

What alternative solutions did you explore? (Optional)

@mollfpr

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix text attachment edit comment bug #42290

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

@mollfpr requires payment through NewDot Manual Requests
@FitseTLT requires payment automatic offer (Contributor)

@mollfpr

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mollfpr

Reminder set to pay, thoughts on BZ steps @mollfpr ?

@mollfpr

Payment summary:

$250 @mollfpr requires payment through NewDot Manual Requests
$250 @FitseTLT requires payment automatic offer (Contributor)

@FitseTLT

Paid and contract ended @FitseTLT

@mollfpr

Sorry for the delay 🙏

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR was found.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is an improvement for a new feature, so the regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to staging.new.expensify.com
Go to chat.
Copy an image (from any source).
Enter text in the composer.
Paste the image via CMD+V.
Send the attachment together with the text.
While the attachment is uploading, right-click on the message
Verify Edit comment is not included in the context menu list
Wait until the attachment is uploaded and open the context menu on the message
Verify Edit comment menu exists and press on it
Check that now the text+attachment message can be edited
👍 or 👎

@MariaHCD

@MariaHCD, @mollfpr, @MitchExpensify, @FitseTLT Huh... This is 4 days overdue. Who can take care of this?

Thank you!

@mollfpr

$250 approved for @mollfpr

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-05] [$250] Chat - Text with attachment message can be edited when the attachment is uploading #40400

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

84 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-06-05] [$250] Chat - Text with attachment message can be edited when the attachment is uploading #40400

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 18, 2024

melvin-bot commented on Apr 18, 2024

github-actions commented on Apr 18, 2024

izarutskaya commented on Apr 18, 2024

izarutskaya commented on Apr 18, 2024

izarutskaya commented on Apr 18, 2024

Nodebrute commented on Apr 18, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

84 remaining items

melvin-bot commented on May 29, 2024

melvin-bot commented on May 29, 2024

MitchExpensify commented on Jun 2, 2024

MitchExpensify commented on Jun 5, 2024

MitchExpensify commented on Jun 5, 2024

mollfpr commented on Jun 10, 2024

melvin-bot commented on Jun 10, 2024

MitchExpensify commented on Jun 11, 2024

JmillsExpensify commented on Jun 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions