Skip to content

[$250] Thread - Unable to upload photo for thread avatar from group chat #40470

New issue
New issue
Closed
Closed
[$250] Thread - Unable to upload photo for thread avatar from group chat#40470
Assignees
sonialiapmarcaaronneonbhaieh2077
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Description

@m-natarajan
m-natarajan
opened on Apr 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Start chat.
  3. Create a group chat.
  4. Send a message in the group chat.
  5. Right click on the message > Reply in thread.
  6. Click on the thread header.
  7. Click on the avatar > Upload photo.
  8. Upload a photo.

Expected Result:

If thread supports custom avatar, photo should be successfully uploaded. If not, there should not be an option to upload avatar.

Actual Result:

After uploading photo, there is no changes in the thread avatar.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453553_1713442307485.20240418_200817.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017775876faefcb133
  • Upwork Job ID: 1781032489627934720
  • Last Price Increase: 2024-04-18
  • Automatic offers:
    • neonbhai | Contributor | 0
    • eh2077 | Contributor | 0

Activity

  1. m-natarajan
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 18, 2024

  2. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot
    assigned
    hayata-suenaga
    and
    sonialiap
    on Apr 18, 2024

  4. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Apr 18, 2024

  6. github-actions commented on Apr 18, 2024

    @github-actions
    github-actionsBot
    on Apr 18, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. m-natarajan commented on Apr 18, 2024

    @m-natarajan
    m-natarajan
    on Apr 18, 2024
    Author

    @sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  8. m-natarajan commented on Apr 18, 2024

    @m-natarajan
    m-natarajan
    on Apr 18, 2024
    Author

    We think this bug might be related to #vip-vsb

  9. neonbhai commented on Apr 18, 2024

    @neonbhai
    neonbhai
    on Apr 18, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Thread - Unable to upload photo for thread avatar from group chat

    What is the root cause of that problem?

    The app doesn't allow us to upload photo for threads in prod.

    We don't add an exception for threads when rendering the avatar here here:

    App/src/pages/ReportDetailsPage.tsx

    Line 230 in a96cc01

    const renderAvatar = isGroupChat ? (

    What changes do you think we should make in order to solve the problem?

    We will had a condition excluding threads here:

    const renderAvatar = isGroupChat && !isThread ? (

    We may use ReportUtils.isThread for isThread

  10. marcaaron commented on Apr 18, 2024

    @marcaaron
    marcaaron
    on Apr 18, 2024
    Contributor

    If thread supports custom avatar, photo should be successfully uploaded. If not, there should not be an option to upload avatar.

    Threads don't support custom avatars.

    This feels like something we should fix.

  11. 15 remaining items

  12. marcaaron commented on Apr 18, 2024

    @marcaaron
    marcaaron
    on Apr 18, 2024
    Contributor

    @hayata-suenaga grabbing this from you since it's related to Group Chats.

  13. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botBot
    on Apr 18, 2024 – with Melvin Bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    HourlyKSv2
    on Apr 19, 2024
  15. mountiny
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 22, 2024
  16. melvin-bot
    added
    MonthlyKSv2
    and removed
    WeeklyKSv2
    on May 13, 2024

  17. melvin-bot commented on May 13, 2024

    @melvin-bot
    melvin-botBot
    on May 13, 2024 – with Melvin Bot

    This issue has not been updated in over 15 days. @sonialiap, @marcaaron, @neonbhai, @eh2077 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  18. neonbhai commented on May 13, 2024

    @neonbhai
    neonbhai
    on May 13, 2024
    Contributor

    PR was merged and deployed to prod 3 weeks ago. Friendly bump to finish payments and close the issue

    cc: @sonialiap

  19. sonialiap commented on May 13, 2024

    @sonialiap
    sonialiap
    on May 13, 2024
    Contributor

    Thanks for the bump. Looks like melvin's automation didn't work here. Reviewing for payment now

  20. sonialiap
    added
    DailyKSv2
    and removed
    MonthlyKSv2
    on May 13, 2024

  21. sonialiap commented on May 13, 2024

    @sonialiap
    sonialiap
    on May 13, 2024
    Contributor

    PR #40563
    No regressions

    Payment summary

  22. sonialiap
    closed this as completedon May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions