[HOLD for payment 2024-05-06] [$250] Workspace - Name RHP stays open while not found view is loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #36409

Action Performed:

Navigate to staging.new.expensify.com
Create a workspace
Go to workspace settings > Profile > Name
While the RHP is open click on URL and change the workspace ID to something invalid
Navigate to it (e.g https://staging.new.expensify.com/settings/workspaces/<invalid
ID>/profile)

Expected Result:

The profile name RHP should close while not found view is loading

Actual Result:

The profile name RHP first closes and then re appears while the not found view is loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6453768_1713453751763.Screen_Recording_20240418_181850_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012247865ed0caacd0
Upwork Job ID: 1782481496034230272
Last Price Increase: 2024-04-22
Automatic offers:

Pujan92 | Reviewer | 0
nkdengineer | Contributor | 0

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@abekkala

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

Name RHP stays open while not found view is loading

What is the root cause of that problem?

After testing, it appears that this error is not limited to the profile page; it also occurs on the description page. There is currently no logic implemented to handle the not-found page scenario.

App/src/pages/workspace/WorkspaceProfileDescriptionPage.tsx

Lines 70 to 78 in 68e6962

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               shouldEnableMaxHeight 
        
               testID={WorkspaceProfileDescriptionPage.displayName} 
        
           > 
        
               <HeaderWithBackButton 
        
                   title={translate('workspace.editor.descriptionInputLabel')} 
        
                   onBackButtonPress={() => Navigation.goBack()} 
        
               />

App/src/pages/workspace/WorkspaceNamePage.tsx

Lines 56 to 64 in 68e6962

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               shouldEnableMaxHeight 
        
               testID={WorkspaceNamePage.displayName} 
        
           > 
        
               <HeaderWithBackButton 
        
                   title={translate('workspace.editor.nameInputLabel')} 
        
                   onBackButtonPress={() => Navigation.goBack()} 
        
               />

What changes do you think we should make in order to solve the problem?

We can implement it similarly to how we're handling the currency selector in the workspace.

App/src/pages/workspace/WorkspaceProfileCurrencyPage.tsx

Lines 78 to 83 in 68e6962

    
           <FullPageNotFoundView 
        
               onBackButtonPress={PolicyUtils.goBackFromInvalidPolicy} 
        
               onLinkPress={PolicyUtils.goBackFromInvalidPolicy} 
        
               shouldShow={(isEmptyObject(policy) && !isLoadingReportData) || !PolicyUtils.isPolicyAdmin(policy) || PolicyUtils.isPendingDeletePolicy(policy)} 
        
               subtitleKey={isEmptyObject(policy) ? undefined : 'workspace.common.notAuthorized'} 
        
           >

We can do something like this

 <FullPageNotFoundView
onBackButtonPress={PolicyUtils.goBackFromInvalidPolicy}
  onLinkPress={PolicyUtils.goBackFromInvalidPolicy}
  shouldShow={(isEmptyObject(policy))|| !PolicyUtils.isPolicyAdmin(policy) || PolicyUtils.isPendingDeletePolicy(policy)}
 subtitleKey={isEmptyObject(policy) ? undefined : 'workspace.common.notAuthorized'}
            >

Result

Screen.Recording.2024-04-19.at.9.41.31.AM.mov

What alternative solutions did you explore? (Optional)

We need to test other areas to see if the bug occurs elsewhere as well.
Regarding the loading indicator, we can utilize withPolicyAndFullscreenLoading if we decide to include it. However, currently, we're fine without it.

Job added to Upwork: https://www.upwork.com/jobs/~012247865ed0caacd0

@Pujan92

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@Pujan92

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix Workspace - Name RHP stays open while not found view is loading #40967

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

@Pujan92 requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)

@Pujan92

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
[@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Pujan92] Determine if we should create a regression test for this bug.
[@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@nkdengineer

PAYMENT SUMMARY FOR MAY 06

Fix: @nkdengineer [$250] requires payment automatic offer
PR Review:@Pujan92 [$250] requires payment automatic offer Please complete checklist

@Pujan92

friendly bump @Pujan92

I think a checklist is not needed here as none of the specific PR caused this.

Regression Test Steps

Goto your workspace -> Profile
Click on the name which opens the RHP for editing the name
In the URL modify the workspace id with any invalid one and hit enter
Verify that not found view is displayed

@Pujan92

@Pujan92 please accept the offer in Upwork and I can process payment - thanks!

@nkdengineer

@nkdengineer payment sent and contract ended - thank you! 🎉

@abekkala

@abekkala Accepted, Thanks!

@Pujan92

@Pujan92 payment sent and contract ended - thank you!

@rlinoz

@rlinoz @abekkala Be sure to fill out the Contact List!

Navigation Menu

Repository navigation

[HOLD for payment 2024-05-06] [$250] Workspace - Name RHP stays open while not found view is loading #40488

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

19 remaining items

PAYMENT SUMMARY FOR MAY 06

Regression Test Steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	shouldEnableMaxHeight
	testID={WorkspaceProfileDescriptionPage.displayName}
	>
	<HeaderWithBackButton
	title={translate('workspace.editor.descriptionInputLabel')}
	onBackButtonPress={() => Navigation.goBack()}
	/>

	<FullPageNotFoundView
	onBackButtonPress={PolicyUtils.goBackFromInvalidPolicy}
	onLinkPress={PolicyUtils.goBackFromInvalidPolicy}
	shouldShow={(isEmptyObject(policy) && !isLoadingReportData) \|\| !PolicyUtils.isPolicyAdmin(policy) \|\| PolicyUtils.isPendingDeletePolicy(policy)}
	subtitleKey={isEmptyObject(policy) ? undefined : 'workspace.common.notAuthorized'}
	>

[HOLD for payment 2024-05-06] [$250] Workspace - Name RHP stays open while not found view is loading #40488

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 18, 2024

lanitochka17 commented on Apr 18, 2024

lanitochka17 commented on Apr 18, 2024

Nodebrute commented on Apr 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Apr 22, 2024

melvin-bot commented on Apr 22, 2024

19 remaining items

melvin-bot commented on Apr 29, 2024

melvin-bot commented on Apr 29, 2024

melvin-bot commented on Apr 29, 2024

abekkala commented on Apr 30, 2024

PAYMENT SUMMARY FOR MAY 06

rlinoz commented on May 3, 2024

Pujan92 commented on May 4, 2024

Pujan92 commented on May 4, 2024

Regression Test Steps

abekkala commented on May 6, 2024

abekkala commented on May 6, 2024

Pujan92 commented on May 6, 2024

abekkala commented on May 7, 2024

melvin-bot commented on May 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions