Skip to content

[Pay meow][$250] Workspace - Workspace type name is not showing in correct column #40524

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): shussain+test@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #39991

Action Performed:

  1. Open a workspace join link that we aren't a member of this (workspace from gmail account)
  2. Check the workspace type name

Expected Result:

Workspace type name should not displayed with "requested" lable

Actual Result:

Workspace type name is not showing in correct column

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454111_1713465637610.2024-04-18_23-30-53.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01740751b07e243f13
  • Upwork Job ID: 1781233221316165632
  • Last Price Increase: 2024-04-19
  • Automatic offers:
    • cubuspl42 | Reviewer | 0
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Apr 19, 2024

    @lanitochka17
    Author

    @marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Apr 19, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. marcaaron commented on Apr 19, 2024

    @marcaaron
    Contributor

    Looks kinda bad so probably should be a blocker?

    2024-04-18_15-51-53

    Got assigned this towards the end of my day and have not investigated yet.

    @luacmartins is this related to Simplified Collect?

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 19, 2024
  7. changed the title [-]Workspace - Workspace type name is not showing in correct column[/-] [+][$250] Workspace - Workspace type name is not showing in correct column[/+] on Apr 19, 2024
  8. melvin-bot commented on Apr 19, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 19, 2024
  10. 29 remaining items

  11. mountiny commented on Apr 22, 2024

    @mountiny
    Contributor

    $250 to @dragnoir and @allroundexperts once the time comes up.

    @dragnoir since this is quite simple PR, could you please also address the follow up from @shawnborton mentioned on the PR to update the style of the three dots padding?

  12. melvin-bot commented on Apr 23, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. melvin-bot commented on Apr 30, 2024

    @melvin-bot

    @dragnoir, @mallenexpensify, @allroundexperts, @mountiny Eep! 4 days overdue now. Issues have feelings too...

  14. melvin-bot commented on May 2, 2024

    @melvin-bot

    @dragnoir, @mallenexpensify, @allroundexperts, @mountiny Still overdue 6 days?! Let's take care of this!

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on May 3, 2024
  16. changed the title [-][$250] Workspace - Workspace type name is not showing in correct column[/-] [+][Pay meow][$250] Workspace - Workspace type name is not showing in correct column[/+] on May 3, 2024
  17. mallenexpensify commented on May 3, 2024

    @mallenexpensify
    Contributor

    Automation failed, payment's due.
    @dragnoir , can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~01740751b07e243f13

  18. dragnoir commented on May 3, 2024

    @dragnoir
    Contributor

    @mallenexpensify offer accepted, thank you

  19. mallenexpensify commented on May 3, 2024

    @mallenexpensify
    Contributor

    Contributor: @dragnoir paid $250 via Upwork
    Contributor+: @allroundexperts owed $250 via NewDot

  20. JmillsExpensify commented on Jun 17, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions