Skip to content

[HOLD for payment 2024-05-09] [$250] Emojis - Large emoji is cut off in preview on iOS and Android app #40535

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR: #39597
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Access the New Expensify app
  2. Sign into a valid account
  3. Go to any chat
  4. Send an Emoji on iOS or Android (Notice that the emoji will be enlarged before typing anything, but if it is not, type a couple of letters to get the emoji to switch sizes)

Expected Result:

User expects the Emoji to fit in the text box

Actual Result:

The emoji is cut in half

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6454381_1713487963082.Emoji_is_cut_in_half_on_iOS_app.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @laurenreidexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ed0b5667ecd2ce23
  • Upwork Job ID: 1782357324514742272
  • Last Price Increase: 2024-04-22
  • Automatic offers:
    • Ollyws | Reviewer | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2024
  2. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 19, 2024

    @izarutskaya
    Author

    @laurenreidexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 19, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  7. izarutskaya commented on Apr 19, 2024

    @izarutskaya
    Author

    Production less cut off

    IMG_3200

  8. thienlnam commented on Apr 20, 2024

    @thienlnam
    Contributor

    Ah, this looks related to the recent emoji changes we added - cc @Skalakid

  9. 29 remaining items

  10. changed the title [-][$250] Emojis - Large emoji is cut off in preview on iOS and Android app[/-] [+][HOLD for payment 2024-05-09] [$250] Emojis - Large emoji is cut off in preview on iOS and Android app[/+] on May 2, 2024
  11. melvin-bot commented on May 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on May 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-09. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on May 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. laurenreidexpensify commented on May 9, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

    • C+ - @Ollyws - offer sent in upwork $250 please accept thanks
    • Contributor - @robertKozik does not require payment (Contractor)
  15. Ollyws commented on May 13, 2024

    @Ollyws
    Contributor

    Accepted thanks!

  16. laurenreidexpensify commented on May 14, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

    C+ - @Ollyws - paid in upwork $250
    Contributor - @robertKozik does not require payment (Contractor)

    No regression test as picked up in KI testing report by Applause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions