[HOLD for payment 2024-05-06] [$250] Quick action - Group chat name and avatar does not update unless the page is refreshed

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-5
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Start chat.
Create a group chat.
Split expense in the group chat.
Click on the chat header.
Go to Settings > Name.
Change the group chat name.
Also change the group chat avatar.
Click FAB.
Hover over the group chat avatar.

Expected Result:

The group chat under Quick action in FAB will update to show the latest avatar and name.

Actual Result:

The group chat under Quick action in FAB does not show the latest avatar and name (in the tooltip) unless the page is refreshed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6454364_1713485468784.20240419_080236.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0158c8e7015a29644e
Upwork Job ID: 1783268294358458368
Last Price Increase: 2024-04-24
Automatic offers:

shubham1206agra | Reviewer | 0
bernhardoj | Contributor | 0

@madmax330

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@isabelastisser

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Quick action - Group chat name and avatar does not update unless the page is refreshed

What is the root cause of that problem?

The main problem with issue is that we can' get actual ActionReport because we use useMemo
As a result, we are unable to update the data

What changes do you think we should make in order to solve the problem?

To fix this issue we can refactor this component and use allReports directly to always have actual information from report

const quickActionReport: OnyxEntry<OnyxTypes.Report> = useMemo(
    () => (quickAction ? allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${quickAction.chatReportID}`] : null),
    [allReports, quickAction],
);

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 150 in bec1c8e

    
           const quickActionReport: OnyxEntry<OnyxTypes.Report> = useMemo(() => (quickAction ? ReportUtils.getReport(quickAction.chatReportID) : null), [quickAction]);

For optimisation we can use selector just like we do for allPolicies on this screen

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 73 to 81 in bec1c8e

    
           const policySelector = (policy: OnyxEntry<OnyxTypes.Policy>): PolicySelector => 
        
               (policy && { 
        
                   type: policy.type, 
        
                   role: policy.role, 
        
                   isPolicyExpenseChatEnabled: policy.isPolicyExpenseChatEnabled, 
        
                   pendingAction: policy.pendingAction, 
        
                   avatar: policy.avatar, 
        
                   name: policy.name, 
        
               }) as PolicySelector;

What alternative solutions did you explore? (Optional)

As alternative we don't have to use useMemo

Reviewing label has been removed, please complete the "BugZero Checklist".

@bernhardoj

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix group chat name and avatar of quick action does not update dynamically #41057

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

@bernhardoj requires payment automatic offer (Contributor)
@shubham1206agra requires payment automatic offer (Reviewer)

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@shubham1206agra

The payments were processed in Upwork.

@shubham1206agra, please complete the BZ list above before I can close the issue. Thanks!

@isabelastisser

The payments were processed in Upwork.

@isabelastisser Can you check this again? Looks like my payment was not processed.

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Display Quick Action Button #38669
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38669/files#r1594826990
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[@shubham1206agra] Determine if we should create a regression test for this bug. No
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Confirming that the payments were processed in Upwork on May 8:

Navigation Menu

Repository navigation

[HOLD for payment 2024-05-06] [$250] Quick action - Group chat name and avatar does not update unless the page is refreshed #40536

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

35 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const policySelector = (policy: OnyxEntry<OnyxTypes.Policy>): PolicySelector =>
	(policy && {
	type: policy.type,
	role: policy.role,
	isPolicyExpenseChatEnabled: policy.isPolicyExpenseChatEnabled,
	pendingAction: policy.pendingAction,
	avatar: policy.avatar,
	name: policy.name,
	}) as PolicySelector;

[HOLD for payment 2024-05-06] [$250] Quick action - Group chat name and avatar does not update unless the page is refreshed #40536

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 19, 2024

melvin-bot commented on Apr 19, 2024

github-actions commented on Apr 19, 2024

izarutskaya commented on Apr 19, 2024

izarutskaya commented on Apr 19, 2024

ZhenjaHorbach commented on Apr 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

35 remaining items

melvin-bot commented on Apr 29, 2024

melvin-bot commented on Apr 29, 2024

melvin-bot commented on Apr 29, 2024

isabelastisser commented on May 8, 2024

shubham1206agra commented on May 9, 2024

shubham1206agra commented on May 9, 2024

isabelastisser commented on May 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions