You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [HOLD for payment 2024-07-10] Split bill - New group is created when splitting bill with the same users #40579
Version Number: 1.4.63-7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4496719 Email or phone of affected tester (no customers):natnael.expensify+3@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Click on FAB > and create a split bill with two new users
Click on FAB > and create another split bill the same two users you have created with on step one
Expected Result:
New group shouldn't be created, and the split bill should be added to the existing group
Actual Result:
A second, new group is created
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
currently getChatByParticipants doesn't include group chats so we should update it to take a parameter includeGroupChats and pass as true here
function getChatByParticipants(newParticipantList: number[], reports: OnyxCollection<Report> = allReports, includeGroupChats = false): OnyxEntry<Report> {
const sortedNewParticipantList = newParticipantList.sort();
return (
Object.values(reports ?? {}).find((report) => {
// If the report has been deleted, or there are no participants (like an empty #admins room) then skip it
if (
!report ||
report.participantAccountIDs?.length === 0 ||
isChatThread(report) ||
isTaskReport(report) ||
isMoneyRequestReport(report) ||
isChatRoom(report) ||
isPolicyExpenseChat(report) ||
(isGroupChat(report) && !includeGroupChats)
What alternative solutions did you explore? (Optional)
Flagged again in Slack. This is definitely #vip-split related. But don't want to make external just yet since I feel like there is a solid chance we will close this.
changed the title [-][HOLD for payment 2024-07-10] Split bill - New group is created when splitting bill with the same users[/-][+][$250] [HOLD for payment 2024-07-10] Split bill - New group is created when splitting bill with the same users[/+]on Jul 12, 2024
Activity
melvin-bot commentedon Apr 19, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Apr 19, 2024
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
FitseTLT commentedon Apr 19, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Split bill - New group is created when splitting bill with the same users
What is the root cause of that problem?
We are not checking if the group chat exists or not before creating here
App/src/libs/actions/IOU.ts
Lines 3104 to 3119 in 9b2c518
What changes do you think we should make in order to solve the problem?
We should check if it already exists in onyx
currently
getChatByParticipantsdoesn't include group chats so we should update it to take a parameterincludeGroupChatsand pass as true hereWhat alternative solutions did you explore? (Optional)
Optonally we can update this line of code
App/src/libs/actions/IOU.ts
Lines 3088 to 3092 in 9b2c518
to
shahinyan11 commentedon Apr 19, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Split bill - New group is created when splitting bill with the same users
What is the root cause of that problem?
New feature
What changes do you think we should make in order to solve the problem?
Add below code above this line
Update this line as follows
getChatByParticipants(participants)?.reportID || ''What alternative solutions did you explore? (Optional)
FitseTLT commentedon Apr 19, 2024
Updated Only to add a refactored code for same solution
joekaufmanexpensify commentedon Apr 19, 2024
I think this report is going to be obviated by a feature refactor we're working on. Discussing.
joekaufmanexpensify commentedon Apr 22, 2024
Not overdue
joekaufmanexpensify commentedon Apr 23, 2024
Bumped in slack
joekaufmanexpensify commentedon Apr 24, 2024
Bumped 1:1
joekaufmanexpensify commentedon Apr 25, 2024
Flagged again in Slack. This is definitely #vip-split related. But don't want to make external just yet since I feel like there is a solid chance we will close this.
83 remaining items
melvin-bot commentedon Jul 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01c9e84f7fad619cd5
[-][HOLD for payment 2024-07-10] Split bill - New group is created when splitting bill with the same users[/-][+][$250] [HOLD for payment 2024-07-10] Split bill - New group is created when splitting bill with the same users[/+]melvin-bot commentedon Jul 12, 2024
Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.
joekaufmanexpensify commentedon Jul 12, 2024
@FitseTLT offer sent for $250!
joekaufmanexpensify commentedon Jul 12, 2024
@Ollyws please request $250 via NewDot whenever you're ready!
FitseTLT commentedon Jul 12, 2024
Accepted
joekaufmanexpensify commentedon Jul 12, 2024
@FitseTLT $250 sent and contract ended!
joekaufmanexpensify commentedon Jul 12, 2024
Upwork job closed.
joekaufmanexpensify commentedon Jul 12, 2024
Closing for now, as only thing left here is for @Ollyws to request their payment. Payment summary is here as FYI.
joekaufmanexpensify commentedon Jul 12, 2024
Thanks everyone!
Ollyws commentedon Jul 13, 2024
Requested in ND.
JmillsExpensify commentedon Jul 16, 2024
$250 approved for @Ollyws