Skip to content

[Hold for Payment 10 August] Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text #4066

Closed
Expensify/expensify-common
#399

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! https://www.upwork.com/jobs/~0112eb53bb4c90676c


Action Performed:

  1. Open e.cash in Web
  2. Navigate to a conversation that has some messages
  3. In a message that only contains text, use the copy function. For web, hover over the message and a menu should appear
  4. Paste the message in a text box

Expected Result:

The message must be shown in the text box without issues

Actual Result:

The size of the compose field there are 2 line breaks before and after the copied text

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number:
1.0.78-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug5152245_Issuecopy_Paste.mp4

Bug5152245_image__3_

Expensify/Expensify Issue URL:

View all open jobs on Upwork

Activity

  1. OSBotify commented on Jul 15, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Jul 15, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. parasharrajat commented on Jul 15, 2021

    @parasharrajat
    Member

    @kavimuru Not able to reproduce, Could you please try pasting the same copied content here http://madebyevan.com/clipboard-test/

    And share the output with us. It will help us debug.

  4. Julesssss commented on Jul 15, 2021

    @Julesssss
    Contributor

    Hi @kavimuru, I'm also not able to reproduce on Chrome, E.cash version v1.0.78-1. I tried a couple of different languages.

    For now I'm removing the labels.

  5. added
    ImprovementItem broken or needs improvement.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 15, 2021
  6. removed their assignment
    on Jul 15, 2021
  7. kavimuru commented on Jul 15, 2021

    @kavimuru
    Author

    Hi @parasharrajat , I'm still able to reproduce with version v1.0.78-1. Attaching video which included reproducible steps and output from http://madebyevan.com/clipboard-test/

    Reproducible.mp4

    Screenshot (370)
    Screenshot (369)

  8. Julesssss commented on Jul 15, 2021

    @Julesssss
    Contributor

    @kavimuru here's what I'm seeing with the same message:

    Screenshot 2021-07-15 at 12 57 59

    Clearly this is still occurring for you so lets keep the issue open, but there's no need to block release for this.

  9. 26 remaining items

  10. laurenreidexpensify commented on Jul 27, 2021

    @laurenreidexpensify
    Contributor

    @Julesssss just a reminder we need to have a Contributor Manager and Contributor Manager Engineer assigned the issue along with the Contributor, so that we can ensure the job is posted to Upwork + the contributor is hired and paid, and that the CME is able to review the PR.

  11. laurenreidexpensify commented on Jul 27, 2021

    @laurenreidexpensify
    Contributor
  12. changed the title [-]Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text[/-] [+][Hold for Payment 4 August] Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text[/+] on Jul 28, 2021
  13. isagoico commented on Aug 2, 2021

    @isagoico

    Issue reproducible during KI retests

  14. parasharrajat commented on Aug 2, 2021

    @parasharrajat
    Member

    Oh sorry I missed to update the lib version on NewDot

  15. changed the title [-][Hold for Payment 4 August] Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text[/-] [+][Hold for Payment 10 August] Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text[/+] on Aug 3, 2021
  16. isagoico commented on Aug 9, 2021

    @isagoico

    Issue not reproducible during KI retests (Fixed 🎉)

  17. laurenreidexpensify commented on Aug 10, 2021

    @laurenreidexpensify
    Contributor

    Paid @parasharrajat 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions