Skip to content

[Awaiting checklist] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN #40680

New issue
New issue
Closed
Closed
[Awaiting checklist] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN#40680
Assignees
BeamanatortwisterdotcomPujan92MonilBhavsar
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Description

@izarutskaya
izarutskaya
opened on Apr 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.62.17
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: https://github.com/Expensify/Expensify/issues/318139
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/r/8813851443373010
  2. Log in with a new Gmail account
  3. Leave the room

Or

  1. Have a room on some policy
  2. Join that room
  3. in new tab, deeplink to that room
  4. Leave it

Expected Result:

LHN should still be visible.

Actual Result:

LHN disappears upon leaving a public room. It returns if the page is refreshed.
On mWeb, iOS and Android you're unable to use the "<" button to go to the LHN from Concierge after leaving the room.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6456699_1713723474319.LHN.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c4dd40ad35562892
  • Upwork Job ID: 1782375600407408640
  • Last Price Increase: 2024-04-22

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 22, 2024
  2. melvin-bot
    assigned
    Beamanator
    and
    twisterdotcom
    on Apr 22, 2024

  3. melvin-bot commented on Apr 22, 2024

    @melvin-bot
    melvin-botBot
    on Apr 22, 2024 – with Melvin Bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 22, 2024

    @melvin-bot
    melvin-botBot
    on Apr 22, 2024 – with Melvin Bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Apr 22, 2024

  6. github-actions commented on Apr 22, 2024

    @github-actions
    github-actionsBot
    on Apr 22, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. izarutskaya commented on Apr 22, 2024

    @izarutskaya
    izarutskaya
    on Apr 22, 2024
    Author

    @twisterdotcom I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  8. izarutskaya commented on Apr 22, 2024

    @izarutskaya
    izarutskaya
    on Apr 22, 2024
    Author

    We think this issue might be related to the #cvip-vsb.

  9. izarutskaya commented on Apr 22, 2024

    @izarutskaya
    izarutskaya
    on Apr 22, 2024
    Author

    Production

    bandicam.2024-04-22.14-40-01-789.mp4

  10. twisterdotcom commented on Apr 22, 2024

    @twisterdotcom
    twisterdotcom
    on Apr 22, 2024
    Contributor

    Okay, I recreated this here:

    40680.mp4

    But I have since recreated it on staging with my normal account, doesn't have to be new, or only have 1 other chat in the LHN. Simply put, leaving a room is broken on staging. It removes the LHN AFAIK if the room is left just after joining.

    Agree this is a deploy blocker.

  11. 42 remaining items

  12. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Apr 29, 2024
  13. melvin-bot
    changed the title [-][$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN[/-] [+][HOLD for payment 2024-05-06] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN[/+] on Apr 29, 2024

  14. melvin-bot commented on Apr 29, 2024

    @melvin-bot
    melvin-botBot
    on Apr 29, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-06. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment (Needs manual offer from BZ)

  15. melvin-bot commented on Apr 29, 2024

    @melvin-bot
    melvin-botBot
    on Apr 29, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
    • [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Pujan92] Determine if we should create a regression test for this bug.
    • [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  16. Beamanator commented on May 22, 2024

    @Beamanator
    Beamanator
    on May 22, 2024
    Contributor

    This looks like it's been ready for payment for a bit @twisterdotcom ? :D

  17. Pujan92 commented on Jun 13, 2024

    @Pujan92
    Pujan92
    on Jun 13, 2024
    Contributor

    Bump @twisterdotcom for the payment if we are not considering the issue #41128 as a regression from here.

  18. twisterdotcom commented on Jun 13, 2024

    @twisterdotcom
    twisterdotcom
    on Jun 13, 2024
    Contributor

    #42073 (comment)

  19. twisterdotcom commented on Jun 14, 2024

    @twisterdotcom
    twisterdotcom
    on Jun 14, 2024
    Contributor

    Payment Summary

    Upwork Job

  20. twisterdotcom commented on Jun 14, 2024

    @twisterdotcom
    twisterdotcom
    on Jun 14, 2024
    Contributor

    LMK if this needs a regression test.

  21. twisterdotcom
    removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jun 14, 2024
  22. twisterdotcom
    changed the title [-][HOLD for payment 2024-05-06] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN[/-] [+][Awaiting checklist] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN[/+] on Jun 14, 2024

  23. Pujan92 commented on Jun 15, 2024

    @Pujan92
    Pujan92
    on Jun 15, 2024
    Contributor

    Regression Test Steps

    1. Copy any public room URL and signout
    2. Visit the copied URL and sign in
    3. Leave that public room
    4. Verify the LHN isn't disappear
  24. twisterdotcom
    closed this as completedon Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions