You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-05-02] Distance - Distance row shows "0.00 miles" instead of "Pending" after changing distance #40712
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Distance - Distance row shows "0.00 miles" instead of "Pending" after changing distance[/-][+][HOLD for payment 2024-05-02] Distance - Distance row shows "0.00 miles" instead of "Pending" after changing distance[/+]on Apr 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Apr 22, 2024
Triggered auto assignment to @amyevans (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Apr 22, 2024
We think that this bug might be related to #wave-collect - Release 1
nexarvo commentedon Apr 22, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance row shows "0.00 miles" instead of "Pending" after changing distance
What is the root cause of that problem?
The
distanceInMetersis 0 when the API response is pending and there is no check if handle that. So it just show distance as 0.00 here:App/src/libs/DistanceRequestUtils.ts
Lines 153 to 156 in b1d25e4
What changes do you think we should make in order to solve the problem?
We can update the condition to handle the pending response logic like:
+ if (!hasRoute || !rate || !unit || distanceInMeters === 0) { return translate('iou.routePending'); }What alternative solutions did you explore? (Optional)
Result
bcc9a239-451e-47a8-b81f-82e894c2237c.mp4
mountiny commentedon Apr 22, 2024
@koko57 @neil-marcellini this might be related to this PR, can you please have a look? #38543
koko57 commentedon Apr 22, 2024
I can fix this in my next PR
mountiny commentedon Apr 22, 2024
@koko57 are you able to expedite that Pr so it can be merged and CPed tomorrow?
koko57 commentedon Apr 22, 2024
yes, of course - the draft is already ready (#40711), let me just add this fix
amyevans commentedon Apr 22, 2024
Perfect, thanks!
koko57 commentedon Apr 22, 2024
@neil-marcellini @mountiny changes pushed, test steps updated
amyevans commentedon Apr 24, 2024
This got CPed, closing!
[-]Distance - Distance row shows "0.00 miles" instead of "Pending" after changing distance[/-][+][HOLD for payment 2024-05-02] Distance - Distance row shows "0.00 miles" instead of "Pending" after changing distance[/+]melvin-bot commentedon Apr 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-05-02. 🎊
For reference, here are some details about the assignees on this issue: