You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Submit Expense - Header Remains as "Submit Expense" Instead of "Manual" #40717
Version Number: v1.4.64.0 Reproducible in staging?: y Reproducible in production?: n Issue found when executing PR:#35822 Issue reported by: Applause - Internal Team
Action Performed:
1, Tap on the FAB > "Submit Expense."
2, Choose the "Manual" option and input the amount.
3, Click "Next." Observe that the header continues to display "Submit Expense" instead of changing to "Manual."
Expected Result:
The header should change to "Manual" after entering the amount and clicking "Next."
Actual Result:
The header remains as "Submit Expense" instead of changing to "Manual" during the expense submission process.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Activity
melvin-bot commentedon Apr 22, 2024
Triggered auto assignment to @francoisl (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Apr 22, 2024
We think that this bug might be related to #vip-split
suneox commentedon Apr 22, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Submit Expense - Header Remains as "Submit Expense" Instead of "Manual"
What is the root cause of that problem?
Regression from new feature implementation
What changes do you think we should make in order to solve the problem?
At this line we should get translation by
requestTypebased on 3 casesDistance,Manual,ScanBase on the
requestTypewe can get translation fromKeep the same with previous release
or
To make consistent with quickAction
What alternative solutions did you explore? (Optional)
francoisl commentedon Apr 22, 2024
Looks like this is expected based on this thread.
There's going to be a follow-up issue to update the headers for all money request flows later (it will also not go back to saying "Manual")
mountiny commentedon Apr 22, 2024
Correct this is no expected behaviour, thanks ❤️