Skip to content

Web - Task - Confirmation page not skipped for assign task flow when accessed from QAB #40719

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Issue found when executing PR: #39413

Action Performed:

Precondition: User A has created task skipping the assignee field. User has selected share somewhere option

  1. Navigate to staging ND site
  2. Tap FAB button
  3. Select shortcut assign task
  4. Enter task title & description

Expected Result:

Assign Task flow skips the confirmation page when task flow accessed from QAB

Actual Result:

Confirmation page not skipped for assign task flow when accessed from QAB

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457588_1713801924958.Recording__151.mp4

image

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Apr 22, 2024

    @melvin-bot

    Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. changed the title [-]Task - Confirmation page not skipped for assign task flow when accessed from QAB[/-] [+]Web - Task - Confirmation page not skipped for assign task flow when accessed from QAB[/+] on Apr 22, 2024
  4. kbecciv commented on Apr 22, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb

  5. chiragsalian commented on Apr 22, 2024

    @chiragsalian
    Contributor

    Not really a blocker. Looks like #39413 is not working as expected and doesn't feel blocker worthy imo. Removing blocker label and reassigning issue to @Gonals since it's an issue with his PR. Feel free to let me know if you need any assistance with this.

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 22, 2024
  7. c3024 commented on Apr 23, 2024

    @c3024
    Contributor

    I think this is expected behaviour. Only when both assignee and share destination are selected does the QAB skip confirmation for tasks. In this case only share destination is selected.

    cc: @Gonals

  8. Gonals commented on Apr 23, 2024

    @Gonals
    Contributor

    I think this is expected behaviour. Only when both assignee and share destination are selected does the QAB skip confirmation for tasks. In this case only share destination is selected.

    Yep. I think that's fine for now. We can revisit this behavior down the line 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions