Skip to content

Taxes - Error shows up when selecting tax rate in split scan menu #40755

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.64-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Collect workspace has a few tax rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a split scan.
  4. When the receipt is scanning, enter amount and merchant.
  5. Click Tax rate.
  6. Select a different tax rate.

Expected Result:

User is able to select a different tax rate without issue.

Actual Result:

Error "Unexpected error editing this expense, please try again later" shows up when selecting a different tax rate.
The selected tax rate is highlighted in tax rate list, but the Tax rate row in split menu still shows the previous tax rate.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6458354_1713850176267.bandicam_2024-04-23_12-52-14-955.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0145ac3902090baef8
  • Upwork Job ID: 1782707567042936832
  • Last Price Increase: 2024-05-07

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 23, 2024
  2. melvin-bot commented on Apr 23, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 23, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Apr 23, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 23, 2024

    @izarutskaya
    Author

    @Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 23, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 23, 2024
  8. changed the title [-]Taxes - Error shows up when selecting tax rate in split scan menu[/-] [+][$250] Taxes - Error shows up when selecting tax rate in split scan menu[/+] on Apr 23, 2024
  9. 33 remaining items

  10. MonilBhavsar commented on May 8, 2024

    @MonilBhavsar
    Contributor

    Those issues do not cover Split Bill flow. So, this issue will not fixed with that PR.

    #39690 does

  11. c3024 commented on May 8, 2024

    @c3024
    Contributor

    Those issues do not cover Split Bill flow. So, this issue will not fixed with that PR.

    #39690 does

    Thanks.

    Sorry for the confusion @Christinadobrzyn. This can be moved to Weekly. Looks like PR for issue #39690 will take some time.

  12. Christinadobrzyn commented on May 14, 2024

    @Christinadobrzyn
    Contributor

    monitoring - #39690

  13. Christinadobrzyn commented on May 21, 2024

    @Christinadobrzyn
    Contributor

    monitoring - #39690

  14. melvin-bot commented on May 28, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. melvin-bot commented on May 28, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. Christinadobrzyn commented on May 28, 2024

    @Christinadobrzyn
    Contributor

    monitoring - #39690

  17. Christinadobrzyn commented on Jun 5, 2024

    @Christinadobrzyn
    Contributor

    monitoring - #39690

  18. Christinadobrzyn commented on Jun 12, 2024

    @Christinadobrzyn
    Contributor

    monitoring - #39690

    Just a heads up - I'm going to be ooo until June 24th. I'm not going to assign anyone new but if you need a new BZ teammate for any reason please feel free to ask for one to be assigned here.

  19. changed the title [-][HOLD Issue 39690][$250] Taxes - Error shows up when selecting tax rate in split scan menu[/-] [+]Taxes - Error shows up when selecting tax rate in split scan menu[/+] on Jun 12, 2024
  20. MonilBhavsar commented on Jun 12, 2024

    @MonilBhavsar
    Contributor

    This bug is fixed, we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions