[HOLD for payment 2024-08-20][$500] WS Chat – Blank page opens when go back from IOU thread in a Collect WS chat

@thesahindia

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.65-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
Log in as Collect WS Employee
In a WS chat create a Submit expense
Open just created Submit expense
Navigate back to WS chat via header link

Expected Result:

Collect WS chat with history opens

Actual Result:

Blank page opens when go back from IOU thread in a Collect WS chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6460580_1713980697854.Blank_page.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dee105cffad79099
Upwork Job ID: 1783269604755496960
Last Price Increase: 2024-06-11
Automatic offers:

jjcoffee | Contributor | 0
tsa321 | Contributor | 103410989

Issue Owner

Current Issue Owner: @thesahindia

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sakluger

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Job added to Upwork: https://www.upwork.com/jobs/~01dee105cffad79099

@jjcoffee

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

Cannot reproduce...

Screen.Recording.2024-04-25.at.01.25.51.mov

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS Chat – Blank page opens when go back from IOU thread in a Collect WS chat

What is the root cause of that problem?

App/src/pages/home/report/ReportActionsView.tsx

Lines 164 to 182 in 0f39e43

    
           const reportActions = useMemo(() => { 
        
               if (!reportActionID) { 
        
                   return combinedReportActions; 
        
               } 
        
               if (isLoading || indexOfLinkedAction === -1) { 
        
                   return []; 
        
               } 
        
               if (isFirstLinkedActionRender.current) { 
        
                   return combinedReportActions.slice(indexOfLinkedAction); 
        
               } 
        
               const paginationSize = getInitialPaginationSize; 
        
               return combinedReportActions.slice(Math.max(indexOfLinkedAction - paginationSize, 0)); 
        
               // currentReportActionID is needed to trigger batching once the report action has been positioned 
        
               // eslint-disable-next-line react-hooks/exhaustive-deps 
        
           }, [reportActionID, combinedReportActions, indexOfLinkedAction, isLoading, currentReportActionID]);

The issue is that when the network is slow, loading is set to true, and then when the page switches, loading remains true, resulting in an empty array being returned. If the page is not refreshed, loading will remain blank, waiting for the response to return.

What changes do you think we should make in order to solve the problem?

remove condition isLoading in Line 169 if not effect another PR. As your comment suggests, even if loading, it shouldn't be blank, should use data what we had. Therefore, I suggest removing it here.

What alternative solutions did you explore? (Optional)

N/A

PR is under review, just one little issue that I think is also there on main, but otherwise testing really well!

@tsa321

I discovered an issue on native (iOS & Android) whilst testing the PR that was also there on main. We decided to fix it as a follow-up and @tsa321 has a solution, so @sakluger would you be able to create an issue and assign us both? (I'm not sure what the process is otherwise!).

Repro steps (video here):

From the main workspace chat, submit an expense request using the + button on the left side of the composer.
Complete the expense request submission process.
Click on the expense preview in the main workspace chat to open the report with all expense previews.
Click on the 3rd expense preview from the last (bottom) expense message/last expense preview. This will open the transaction thread report.
Immediately go back by clicking on the header link.
Try to scroll down

@sakluger

Deployed to production 13 Aug, @sakluger can you update the title to hold for payment for 20 Aug? 🙏

The PR that introduced the bug has been identified. Link to the PR: HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking #30269
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30269/files#r1642624582
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - comment linking was a complex PR so it makes sense some issues were missed
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

If there aren't already, add some expenses to any workspace chat, e.g. 5.
Open each expense to view the transaction details report.
Go back to the workspace chat and submit a new expense using the + button on the left side of the composer.
Click on the expense preview in the chat to open the report with all expense previews.
Click on the 3rd expense from the bottom. This will open the transaction thread report.
Immediately go back by clicking on the header link.
Verify that there is no loading skeleton in the report and that the message loads immediately.

Do we agree 👍 or 👎

@sakluger

@sakluger Payment is due today, as this was deployed 13 Aug.

@marcaaron

@marcaaron Are you able to create the follow-up issue we discussed? Details here. Or is there some other process we should follow?

yes, report bug in #expensify-bugs

@sakluger

@sakluger Friendly bump for payment (the fix was deployed 13 Aug) 🙏

@tsa321

Summarizing payment on this issue:

Contributor: @tsa321 $500, paid via Upwork
Contributor+: @jjcoffee $500, paid via Upwork

@jjcoffee

@jjcoffee thanks for being on top of everything here! And sorry for the delayed payment. All done now 🙇

@sakluger

@sakluger Thanks for making the payment! It looks like the job price didn't update to $500, any way you can correct it?

@jjcoffee

@jjcoffee - sorry about that! I added a $250 bonus to the contract to bring the total payment to $500.

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-20][$500] WS Chat – Blank page opens when go back from IOU thread in a Collect WS chat #40937

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

158 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development


	const reportActions = useMemo(() => {
	if (!reportActionID) {
	return combinedReportActions;
	}
	if (isLoading \|\| indexOfLinkedAction === -1) {
	return [];
	}

	if (isFirstLinkedActionRender.current) {
	return combinedReportActions.slice(indexOfLinkedAction);
	}
	const paginationSize = getInitialPaginationSize;
	return combinedReportActions.slice(Math.max(indexOfLinkedAction - paginationSize, 0));

	// currentReportActionID is needed to trigger batching once the report action has been positioned
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [reportActionID, combinedReportActions, indexOfLinkedAction, isLoading, currentReportActionID]);

[HOLD for payment 2024-08-20][$500] WS Chat – Blank page opens when go back from IOU thread in a Collect WS chat #40937

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 24, 2024

lanitochka17 commented on Apr 24, 2024

lanitochka17 commented on Apr 24, 2024

melvin-bot commented on Apr 24, 2024

melvin-bot commented on Apr 24, 2024

beodw commented on Apr 25, 2024

charles-liang commented on Apr 25, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

158 remaining items

jjcoffee commented on Aug 7, 2024

jjcoffee commented on Aug 12, 2024

jjcoffee commented on Aug 16, 2024

jjcoffee commented on Aug 20, 2024

jjcoffee commented on Aug 20, 2024

jjcoffee commented on Aug 20, 2024

marcaaron commented on Aug 20, 2024

jjcoffee commented on Aug 23, 2024

sakluger commented on Aug 24, 2024

sakluger commented on Aug 24, 2024

jjcoffee commented on Aug 26, 2024

sakluger commented on Sep 4, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions